Issue 19541005: Deprecate some debugger methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19541005: Deprecate some debugger methods (Closed)

Created:
7 years, 5 months ago by yurys

Modified:
7 years, 5 months ago

Reviewers:
Yang, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Deprecate some debugger methods These methods have been superceeded by equivalents accepting object arguments exposing more details. This is exactly the same change as r15708 which was reverted in r15710 due to pending Blink changes. Now that Blink is rolled to 154493 it should be safe to land this (required Blink change is 154386). BUG=None TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15769

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -13 lines)			Patch
M	include/v8-debug.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/d8.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/d8-debug.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/d8-debug.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 5 months ago (2013-07-19 09:38:26 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r15769 (presubmit successful).

Expand Messages | Collapse Messages