Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1954093003: Don't try to paint graphics layers inside throttled frames (Closed)

Created:
4 years, 7 months ago by Sami
Modified:
4 years, 7 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to paint graphics layers inside throttled frames Previously painting was skipped for PaintLayers that correspond to throttled FrameViews. This could still result in the painting of child PaintLayers that are not FrameViews but still reside in a throttled FrameView. This patch amends the paint suppression logic to skip all layers whose containing view is throttled. We also avoid requiring a clean layout for such layers since throttling means the layout can be out of date. BUG=609757 Committed: https://crrev.com/8d0f39db6e6aa60e17c38e2ed7ace717baceef86 Cr-Commit-Position: refs/heads/master@{#393106}

Patch Set 1 #

Patch Set 2 : Add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sami
PTAL. Note that I'm also changing FramePainter::paintContents() to bail out if throttling, since it doesn't ...
4 years, 7 months ago (2016-05-11 18:33:55 UTC) #2
Xianzhu
lgtm
4 years, 7 months ago (2016-05-11 18:44:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954093003/20001
4 years, 7 months ago (2016-05-11 18:44:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/220040)
4 years, 7 months ago (2016-05-11 22:18:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954093003/20001
4 years, 7 months ago (2016-05-11 22:23:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 23:38:51 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 23:40:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d0f39db6e6aa60e17c38e2ed7ace717baceef86
Cr-Commit-Position: refs/heads/master@{#393106}

Powered by Google App Engine
This is Rietveld 408576698