Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1954073003: Convert //services/js/echo_apptest.cc to use SynchronousInterfacePtr. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Convert //services/js/echo_apptest.cc to use SynchronousInterfacePtr. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/ae8c016426a92c2d449b2df8641fa05309b5823e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -49 lines) Patch
M services/js/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/js/echo_apptest.cc View 4 chunks +9 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-06 20:48:54 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-06 21:25:21 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-06 22:25:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ae8c016426a92c2d449b2df8641fa05309b5823e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698