Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1954033002: Remove deprecated uses of WeakCallbackData from i18n. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove deprecated uses of WeakCallbackData from i18n. BUG=chromium:609808 LOG=NO Committed: https://crrev.com/1f6be3d73ce74460bed4c7a8b4ebec79e446fbe0 Cr-Commit-Position: refs/heads/master@{#36077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -53 lines) Patch
M src/i18n.h View 4 chunks +4 lines, -8 lines 0 comments Download
M src/i18n.cc View 4 chunks +12 lines, -33 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal
4 years, 7 months ago (2016-05-06 12:02:12 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-06 12:07:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954033002/1
4 years, 7 months ago (2016-05-06 12:09:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 12:39:51 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 12:42:11 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1f6be3d73ce74460bed4c7a8b4ebec79e446fbe0
Cr-Commit-Position: refs/heads/master@{#36077}

Powered by Google App Engine
This is Rietveld 408576698