Issue 19540003: Use getAttribute instead of fastGetAttribute for SVG animated types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19540003: Use getAttribute instead of fastGetAttribute for SVG animated types (Closed)

Created:
7 years, 5 months ago by do-not-use

Modified:
7 years, 5 months ago

Reviewers:
haraken, abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use getAttribute instead of fastGetAttribute for SVG animated types While there is currently no attribute of SVG animated type marked to [Reflect], adding a check to avoid future problems would be as much code as adding proper support for it. IsSVGAnimatedType() sunbroutine is also simplified so that we don't need to hardcode the SVG Animated types anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154389

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	Source/bindings/scripts/deprecated_code_generator_v8.pm	View		3 chunks	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19540003/1

7 years, 5 months ago (2013-07-17 08:08:56 UTC) #3

Message was sent while issue was closed.

Change committed as 154389

Expand Messages | Collapse Messages