ui/views/window/dialog_client_view.cc - Issue 1953943003: In dialogs & dialog-like bubbles, make the escape button just close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/window/dialog_client_view.cc

Issue 1953943003: In dialogs & dialog-like bubbles, make the escape button just close (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: elaborate test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc ('k') | ui/views/window/dialog_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/window/dialog_client_view.cc

diff --git a/ui/views/window/dialog_client_view.cc b/ui/views/window/dialog_client_view.cc

index eee682637d7989c4cf37fec65aafa7c347b8b6cd..358c81c39120b8afa346769ccd0d77a8c3ee1bc2 100644

--- a/ui/views/window/dialog_client_view.cc

+++ b/ui/views/window/dialog_client_view.cc

@@ -215,10 +215,6 @@ void DialogClientView::Layout() {

bool DialogClientView::AcceleratorPressed(const ui::Accelerator& accelerator) {

DCHECK_EQ(accelerator.key_code(), ui::VKEY_ESCAPE);

- // If there's a cancel button, it handles escape.

- if (cancel_button_)

- return cancel_button_->AcceleratorPressed(accelerator);

GetWidget()->Close();

return true;

}