Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector.h

Issue 1953943003: In dialogs & dialog-like bubbles, make the escape button just close (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: elaborate test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ssl_client_certificate_selector.h
diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector.h b/chrome/browser/ui/views/ssl_client_certificate_selector.h
index 621d05f2766882badd601048709c2721bf89f7f1..24ec62b6b035d1e7685888c1d1c45b5b74646f92 100644
--- a/chrome/browser/ui/views/ssl_client_certificate_selector.h
+++ b/chrome/browser/ui/views/ssl_client_certificate_selector.h
@@ -9,6 +9,7 @@
#include "chrome/browser/ssl/ssl_client_auth_observer.h"
#include "chrome/browser/ssl/ssl_client_certificate_selector.h"
#include "chrome/browser/ui/views/certificate_selector.h"
+#include "content/public/browser/web_contents_observer.h"
// This header file exists only for testing. Chrome should access the
// certificate selector only through the cross-platform interface
@@ -24,7 +25,8 @@ class X509Certificate;
}
class SSLClientCertificateSelector : public chrome::CertificateSelector,
- public SSLClientAuthObserver {
+ public SSLClientAuthObserver,
+ public content::WebContentsObserver {
public:
SSLClientCertificateSelector(
content::WebContents* web_contents,
@@ -38,9 +40,11 @@ class SSLClientCertificateSelector : public chrome::CertificateSelector,
void OnCertSelectedByNotification() override;
// chrome::CertificateSelector:
- bool Cancel() override;
+ void DeleteDelegate() override;
bool Accept() override;
- bool Close() override;
+
+ // content::WebContentsObserver:
+ void WebContentsDestroyed() override;
private:
// Callback after unlocking certificate slot.
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | chrome/browser/ui/views/ssl_client_certificate_selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698