Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: ui/views/window/dialog_client_view.cc

Issue 1953943003: In dialogs & dialog-like bubbles, make the escape button just close (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/window/dialog_client_view.cc
diff --git a/ui/views/window/dialog_client_view.cc b/ui/views/window/dialog_client_view.cc
index eee682637d7989c4cf37fec65aafa7c347b8b6cd..358c81c39120b8afa346769ccd0d77a8c3ee1bc2 100644
--- a/ui/views/window/dialog_client_view.cc
+++ b/ui/views/window/dialog_client_view.cc
@@ -215,10 +215,6 @@ void DialogClientView::Layout() {
bool DialogClientView::AcceleratorPressed(const ui::Accelerator& accelerator) {
DCHECK_EQ(accelerator.key_code(), ui::VKEY_ESCAPE);
- // If there's a cancel button, it handles escape.
msw 2016/05/10 18:23:32 I like this behavior with the bookmark bubble, and
- if (cancel_button_)
- return cancel_button_->AcceleratorPressed(accelerator);
-
GetWidget()->Close();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698