Revise accessibility for Date/TimeView.

Revise accessibility for Date/TimeView.

- make it so that accessible labels get set for both Time and Date views (previously only set on DateView).
- prioritize the time first, then the date in the accessible label itself.
- make it so ChromeVox uses the on-screen-ish label (requires some amount of tree interrogation).
- ensure the name is actually updated when the text changes
- this makes it so ChromeVox reads the time and date, from a source that knows how it should be formatted.
- still fallback to something when time is unavailable on-screen.

BUG=605833
TEST=invoke ChromeVox read time command; do this with 24/12 hour time set. Observe proper output and that time continues to be updated as time passes.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f289d70ec84f5421e7d69e07fc122fa5fbee23d5
Cr-Commit-Position: refs/heads/master@{#392156}

[David Tseng, 2016-05-05 21:14:28]

Description was changed from

==========
Revise accessibility for Date/TimeView.
==========

to

==========
Revise accessibility for Date/TimeView.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-05-05 21:19:04]

Description was changed from

==========
Revise accessibility for Date/TimeView.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revise accessibility for Date/TimeView.

- make it so that accessible labels get set for both Time and Date views
(previously only set on DateView).
- prioritize the time first, then the date in the accessible label itself.
- make it so ChromeVox uses the on-screen-ish label (requires some amount of
tree interrogation).
- ensure the name is actually updated when the text changes
- this makes it so ChromeVox reads the time and date, from a source that knows
how it should be formatted.
- still fallback to something when time is unavailable on-screen.

BUG=605833
TEST=invoke ChromeVox read time command; do this with 24/12 hour time set.
Observe proper output and that time continues to be updated as time passes.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-05-05 21:19:04]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org, skuhne@chromium.org

[dmazzoni, 2016-05-06 15:53:14]

lgtm

https://codereview.chromium.org/1953913002/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

https://codereview.chromium.org/1953913002/diff/1/ash/system/date/date_view.c...
ash/system/date/date_view.cc:98: state->role = ui::AX_ROLE_TIME;
FYI, there is a AX_ROLE_DATE_TIME, would that be better?

https://codereview.chromium.org/1953913002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1953913002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:640:
var allTime = d.findAll({role: RoleType.time});
Not for this change, but I think it'd be useful if we
could do a findAll but limit to one tree.

[Mr4D (OOO till 08-26), 2016-05-06 16:37:49]

Please address dmazzoni's comments first, then lgtm

[David Tseng, 2016-05-06 20:40:14]

https://codereview.chromium.org/1953913002/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

https://codereview.chromium.org/1953913002/diff/1/ash/system/date/date_view.c...
ash/system/date/date_view.cc:98: state->role = ui::AX_ROLE_TIME;
On 2016/05/06 15:53:14, dmazzoni wrote:
> FYI, there is a AX_ROLE_DATE_TIME, would that be better?

It's a toss up because this base class is really Base Date or Time View (given
the two subclasses). Leaving as is for brevity.

https://codereview.chromium.org/1953913002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1953913002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:640:
var allTime = d.findAll({role: RoleType.time});
On 2016/05/06 15:53:14, dmazzoni wrote:
> Not for this change, but I think it'd be useful if we
> could do a findAll but limit to one tree.

Agreed; in this case, it would involve a leaf predicate that restricts
descending into rootWebArea nodes and a root predicate for desktop (and
descending into an initial subtree). (a tree "cutout"). I have a cl to do this
in the works.

[David Tseng, 2016-05-06 20:40:19]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-05-06 20:40:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953913002/1

[commit-bot: I haz the power, 2016-05-06 21:16:38]

Description was changed from

==========
Revise accessibility for Date/TimeView.

- make it so that accessible labels get set for both Time and Date views
(previously only set on DateView).
- prioritize the time first, then the date in the accessible label itself.
- make it so ChromeVox uses the on-screen-ish label (requires some amount of
tree interrogation).
- ensure the name is actually updated when the text changes
- this makes it so ChromeVox reads the time and date, from a source that knows
how it should be formatted.
- still fallback to something when time is unavailable on-screen.

BUG=605833
TEST=invoke ChromeVox read time command; do this with 24/12 hour time set.
Observe proper output and that time continues to be updated as time passes.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revise accessibility for Date/TimeView.

- make it so that accessible labels get set for both Time and Date views
(previously only set on DateView).
- prioritize the time first, then the date in the accessible label itself.
- make it so ChromeVox uses the on-screen-ish label (requires some amount of
tree interrogation).
- ensure the name is actually updated when the text changes
- this makes it so ChromeVox reads the time and date, from a source that knows
how it should be formatted.
- still fallback to something when time is unavailable on-screen.

BUG=605833
TEST=invoke ChromeVox read time command; do this with 24/12 hour time set.
Observe proper output and that time continues to be updated as time passes.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-06 21:16:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-06 21:18:19]

Description was changed from

==========
Revise accessibility for Date/TimeView.

- make it so that accessible labels get set for both Time and Date views
(previously only set on DateView).
- prioritize the time first, then the date in the accessible label itself.
- make it so ChromeVox uses the on-screen-ish label (requires some amount of
tree interrogation).
- ensure the name is actually updated when the text changes
- this makes it so ChromeVox reads the time and date, from a source that knows
how it should be formatted.
- still fallback to something when time is unavailable on-screen.

BUG=605833
TEST=invoke ChromeVox read time command; do this with 24/12 hour time set.
Observe proper output and that time continues to be updated as time passes.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revise accessibility for Date/TimeView.

- make it so that accessible labels get set for both Time and Date views
(previously only set on DateView).
- prioritize the time first, then the date in the accessible label itself.
- make it so ChromeVox uses the on-screen-ish label (requires some amount of
tree interrogation).
- ensure the name is actually updated when the text changes
- this makes it so ChromeVox reads the time and date, from a source that knows
how it should be formatted.
- still fallback to something when time is unavailable on-screen.

BUG=605833
TEST=invoke ChromeVox read time command; do this with 24/12 hour time set.
Observe proper output and that time continues to be updated as time passes.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f289d70ec84f5421e7d69e07fc122fa5fbee23d5
Cr-Commit-Position: refs/heads/master@{#392156}
==========

[commit-bot: I haz the power, 2016-05-06 21:18:20]

Patchset 1 (id:??) landed as
https://crrev.com/f289d70ec84f5421e7d69e07fc122fa5fbee23d5
Cr-Commit-Position: refs/heads/master@{#392156}