Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 19539003: Introduce toSVGUseElement(), use it (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive
Modified:
7 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), adamk+blink_chromium.org, jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toSVGUseElement(), use it As a step to change static_cast with toSVGXXX, static_cast<SVGUseElement*> can be changed with toSVGUseElement(). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154609

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M Source/core/dom/EventRetargeter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyledElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
gyuyoung-inactive
Add tkent as reviewer.
7 years, 5 months ago (2013-07-18 05:46:07 UTC) #1
tkent
lgtm
7 years, 5 months ago (2013-07-18 05:50:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19539003/1
7 years, 5 months ago (2013-07-18 05:50:18 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-18 06:04:07 UTC) #4
gyuyoung-inactive
On 2013/07/18 06:04:07, I haz the power (commit-bot) wrote: > Sorry for I got bad ...
7 years, 5 months ago (2013-07-18 23:09:39 UTC) #5
gyuyoung-inactive
On 2013/07/18 23:09:39, gyuyoung wrote: > On 2013/07/18 06:04:07, I haz the power (commit-bot) wrote: ...
7 years, 5 months ago (2013-07-18 23:37:00 UTC) #6
gyuyoung-inactive
On 2013/07/18 23:37:00, gyuyoung wrote: > On 2013/07/18 23:09:39, gyuyoung wrote: > > On 2013/07/18 ...
7 years, 5 months ago (2013-07-19 02:20:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19539003/15001
7 years, 5 months ago (2013-07-19 02:29:45 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests ...
7 years, 5 months ago (2013-07-19 02:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19539003/15001
7 years, 5 months ago (2013-07-19 03:36:58 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests ...
7 years, 5 months ago (2013-07-19 04:41:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19539003/15001
7 years, 5 months ago (2013-07-19 08:15:30 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests ...
7 years, 5 months ago (2013-07-19 08:24:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19539003/15001
7 years, 5 months ago (2013-07-19 10:16:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19539003/38001
7 years, 5 months ago (2013-07-20 09:47:29 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=315
7 years, 5 months ago (2013-07-20 13:28:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19539003/38001
7 years, 5 months ago (2013-07-21 09:00:31 UTC) #17
commit-bot: I haz the power
7 years, 5 months ago (2013-07-21 09:43:11 UTC) #18
Message was sent while issue was closed.
Change committed as 154609

Powered by Google App Engine
This is Rietveld 408576698