Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1953893004: Suggest 'var' and 'final' in intializer of 'for'. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 3 chunks +31 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-06 20:44:11 UTC) #1
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-06 20:48:47 UTC) #2
scheglov
4 years, 7 months ago (2016-05-06 20:49:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3775d92000c92e4c2d9a3e13ebe8854cb467f657 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698