Add rudimentary shelf delegate mus unit test.

Add rudimentary shelf delegate mus unit test.

Add simple mash shelf tests:
- ash_sysui (which hosts the shelf) draws a window.
- simple use of ShelfController/ShelfObserver interfaces.

BUG=557406
TEST=Tests pass
R=sky@chromium.org

Committed: https://crrev.com/e3f59d3dfe3ec367a7ba4d2109d41fc6f2784088
Cr-Commit-Position: refs/heads/master@{#393700}

[msw, 2016-05-13 19:12:26]

Description was changed from

==========
Add rudimentary shelf delegate mus unit test.

BUG=
==========

to

==========
Add rudimentary shelf delegate mus unit test.

Add simple mash shelf tests:
- ash_sysui (which hosts the shelf) draws a window.
- simple use of ShelfController/ShelfObserver interfaces.

BUG=557406
TEST=Tests pass
R=sky@chromium.org
==========

[msw, 2016-05-13 19:12:26]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-05-13 19:15:24]

Patchset #5 (id:80001) has been deleted

[msw, 2016-05-13 19:15:29]

Patchset #4 (id:60001) has been deleted

[msw, 2016-05-13 19:15:34]

Patchset #4 (id:100001) has been deleted

[msw, 2016-05-13 19:16:55]

Patchset #4 (id:120001) has been deleted

[msw, 2016-05-13 19:17:59]

Hey Scott, please take a look; thanks!

[msw, 2016-05-13 19:18:08]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 19:18:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953893003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953893003/140001

[sky, 2016-05-13 19:35:18]

Nice, LGTM

https://codereview.chromium.org/1953893003/diff/140001/ash/mus/shelf_delegate...
File ash/mus/shelf_delegate_mus_unittest.cc (right):

https://codereview.chromium.org/1953893003/diff/140001/ash/mus/shelf_delegate...
ash/mus/shelf_delegate_mus_unittest.cc:102: bool success = false;
nit: success -> drawn?

[msw, 2016-05-13 19:44:51]

https://codereview.chromium.org/1953893003/diff/140001/ash/mus/shelf_delegate...
File ash/mus/shelf_delegate_mus_unittest.cc (right):

https://codereview.chromium.org/1953893003/diff/140001/ash/mus/shelf_delegate...
ash/mus/shelf_delegate_mus_unittest.cc:102: bool success = false;
On 2016/05/13 19:35:18, sky wrote:
> nit: success -> drawn?

Done.

[msw, 2016-05-13 19:44:55]

The CQ bit was checked by msw@chromium.org

[msw, 2016-05-13 19:44:55]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1953893003/#ps160001
(title: "Address nit.")

[commit-bot: I haz the power, 2016-05-13 19:45:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953893003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953893003/160001

[sadrul, 2016-05-13 19:50:28]

sadrul@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-05-13 19:50:28]

The first test is in https://codereview.chromium.org/1916043007/ too, but it ran
into the deadlock issue that we were seeing in browser_tests

[sky, 2016-05-13 19:55:35]

Ken says it should be fine to land this. He has fixed most of the
issues at this point. He says there is one remaining patch out for
review that fixes another rare case that should land next week.

  -Scott

On Fri, May 13, 2016 at 12:50 PM,  <sadrul@chromium.org> wrote:
> The first test is in https://codereview.chromium.org/1916043007/ too, but it
> ran
> into the deadlock issue that we were seeing in browser_tests
>
> https://codereview.chromium.org/1953893003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-05-13 21:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 21:36:48]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-05-13 21:47:05]

On 2016/05/13 21:36:48, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Yeah, this looks like the old timeout issue. Some of the trybots at least are
still seeing this issue. Perhaps these need Ken's remaining fix(es).

[Ken Rockot(use gerrit already), 2016-05-13 21:51:20]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-05-13 21:51:20]

Are the failures to load mash_session.mojo not an issue?

[sadrul, 2016-05-13 22:38:15]

On 2016/05/13 21:51:20, Ken Rockot wrote:
> Are the failures to load mash_session.mojo not an issue?

Oh, heh yeah, good call. Didn't notice that, sorry. That's probably it then.

[msw, 2016-05-13 22:58:20]

Added "//mash/session" to data_deps.
Sadrul, lmk if I should nix ShelfDelegateMusTest.AshSysUIHasDrawnWindow (since
it's entirely redundant with your test).

[msw, 2016-05-13 22:58:25]

The CQ bit was checked by msw@chromium.org

[msw, 2016-05-13 22:58:25]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1953893003/#ps180001
(title: "Add //mash/session data_dep.")

[commit-bot: I haz the power, 2016-05-13 22:59:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953893003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953893003/180001

[commit-bot: I haz the power, 2016-05-14 00:20:03]

Description was changed from

==========
Add rudimentary shelf delegate mus unit test.

Add simple mash shelf tests:
- ash_sysui (which hosts the shelf) draws a window.
- simple use of ShelfController/ShelfObserver interfaces.

BUG=557406
TEST=Tests pass
R=sky@chromium.org
==========

to

==========
Add rudimentary shelf delegate mus unit test.

Add simple mash shelf tests:
- ash_sysui (which hosts the shelf) draws a window.
- simple use of ShelfController/ShelfObserver interfaces.

BUG=557406
TEST=Tests pass
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-05-14 00:20:04]

Committed patchset #6 (id:180001)

[commit-bot: I haz the power, 2016-05-14 00:21:23]

Description was changed from

==========
Add rudimentary shelf delegate mus unit test.

Add simple mash shelf tests:
- ash_sysui (which hosts the shelf) draws a window.
- simple use of ShelfController/ShelfObserver interfaces.

BUG=557406
TEST=Tests pass
R=sky@chromium.org
==========

to

==========
Add rudimentary shelf delegate mus unit test.

Add simple mash shelf tests:
- ash_sysui (which hosts the shelf) draws a window.
- simple use of ShelfController/ShelfObserver interfaces.

BUG=557406
TEST=Tests pass
R=sky@chromium.org

Committed: https://crrev.com/e3f59d3dfe3ec367a7ba4d2109d41fc6f2784088
Cr-Commit-Position: refs/heads/master@{#393700}
==========

[commit-bot: I haz the power, 2016-05-14 00:21:24]

Patchset 6 (id:??) landed as
https://crrev.com/e3f59d3dfe3ec367a7ba4d2109d41fc6f2784088
Cr-Commit-Position: refs/heads/master@{#393700}

[Ken Rockot(use gerrit already), 2016-05-15 00:36:29]

A revert of this CL (patchset #6 id:180001) has been created in
https://codereview.chromium.org/1979103002/ by rockot@chromium.org.

The reason for reverting is: Boo, sorry, looks like they're timing out on the
bot :(.