Fix invalid using decl in bionic relocation_packer

Fix invalid using decl in bionic relocation_packer

The code was essentially doing 'using Logger::INFO' in the global
namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does
not allow you to use using decls on classes like this unless you are in
a derived class. GCC does not accept this code, and Clang was recently
updated (LLVM r268594) to reject it as well.

This should fix the Chromium Android ASan build with TOT Clang:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/

I'll send this patch along to AOSP after fixing it here.

R=thakis@chromium.org,sgurun@chromium.org
BUG=609543
Committed: https://crrev.com/4fbaaecb9433f9503946be68d0ecef63a1b4a164
Cr-Commit-Position: refs/heads/master@{#391920}

[Nico, 2016-05-05 18:43:44]

lgtm

[sgurun-gerrit only, 2016-05-05 20:23:07]

On 2016/05/05 18:43:44, Nico wrote:
> lgtm

lgtm stamp

[Reid Kleckner, 2016-05-05 20:38:01]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2016-05-05 20:38:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953863002/1

[commit-bot: I haz the power, 2016-05-05 21:57:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-05 21:58:43]

Description was changed from

==========
Fix invalid using decl in bionic relocation_packer

The code was essentially doing 'using Logger::INFO' in the global
namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does
not allow you to use using decls on classes like this unless you are in
a derived class. GCC does not accept this code, and Clang was recently
updated (LLVM r268594) to reject it as well.

This should fix the Chromium Android ASan build with TOT Clang:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/

I'll send this patch along to AOSP after fixing it here.

R=thakis@chromium.org,sgurun@chromium.org
BUG=609543
==========

to

==========
Fix invalid using decl in bionic relocation_packer

The code was essentially doing 'using Logger::INFO' in the global
namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does
not allow you to use using decls on classes like this unless you are in
a derived class. GCC does not accept this code, and Clang was recently
updated (LLVM r268594) to reject it as well.

This should fix the Chromium Android ASan build with TOT Clang:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/

I'll send this patch along to AOSP after fixing it here.

R=thakis@chromium.org,sgurun@chromium.org
BUG=609543

Committed: https://crrev.com/4fbaaecb9433f9503946be68d0ecef63a1b4a164
Cr-Commit-Position: refs/heads/master@{#391920}
==========

[commit-bot: I haz the power, 2016-05-05 21:58:44]

Patchset 1 (id:??) landed as
https://crrev.com/4fbaaecb9433f9503946be68d0ecef63a1b4a164
Cr-Commit-Position: refs/heads/master@{#391920}

[Reid Kleckner, 2016-05-05 22:17:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1959513002/ by rnk@chromium.org.

The reason for reverting is: Broke Android builds due to missing namespace
qualifier.