Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1953833002: Revert of Use correct clip container when computing acl for scroll children (Closed)

Created:
4 years, 7 months ago by chrishtr
Modified:
4 years, 7 months ago
Reviewers:
Ian Vollick, Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use correct clip container when computing acl for scroll children (patchset #3 id:40001 of https://codereview.chromium.org/1863143002/ ) Reason for revert: Caused issue 608410 Original issue's description: > Use correct clip container when computing acl for scroll children > > Kudos to erick@ for the reduced test case. > > BUG=603997 > > Committed: https://crrev.com/94d5fad34f0351e61fd658ca4ed93648c415620d > Cr-Commit-Position: refs/heads/master@{#390199} TBR=wangxianzhu@chromium.org,vollick@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603997, 608410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
chrishtr
Created Revert of Use correct clip container when computing acl for scroll children
4 years, 7 months ago (2016-05-05 18:32:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953833002/1
4 years, 7 months ago (2016-05-05 18:33:44 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 18:37:30 UTC) #5
Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698