Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1953803002: Remove remaining uses of KeySystemInfo and InitDataTypeMask (Closed)

Created:
4 years, 7 months ago by halliwell
Modified:
4 years, 7 months ago
Reviewers:
Nico, ddorwin, pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining uses of KeySystemInfo and InitDataTypeMask This converts external ClearKey to KeySystemProperties, and removes all KeySystemInfo + InitDataTypeMask usage. BUG=457438 Committed: https://crrev.com/d81cefb589e700ab30d1d951ca1294bd50ed3519 Cr-Commit-Position: refs/heads/master@{#392329}

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -375 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 1 6 chunks +87 lines, -43 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/render_media_client.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/media/render_media_client_unittest.cc View 1 chunk +46 lines, -29 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/eme_constants.h View 2 chunks +0 lines, -7 lines 0 comments Download
D media/base/key_system_info.h View 1 chunk +0 lines, -59 lines 0 comments Download
D media/base/key_system_info.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M media/base/key_system_properties.h View 2 chunks +0 lines, -34 lines 0 comments Download
M media/base/key_systems.cc View 11 chunks +0 lines, -145 lines 0 comments Download
M media/blink/key_system_config_selector_unittest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
halliwell
4 years, 7 months ago (2016-05-05 17:20:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953803002/1
4 years, 7 months ago (2016-05-05 17:20:34 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 19:16:00 UTC) #7
ddorwin
LGTM % nits. Thanks! https://codereview.chromium.org/1953803002/diff/1/chrome/renderer/media/chrome_key_systems.cc File chrome/renderer/media/chrome_key_systems.cc (right): https://codereview.chromium.org/1953803002/diff/1/chrome/renderer/media/chrome_key_systems.cc#newcode60 chrome/renderer/media/chrome_key_systems.cc:60: // KeySystemProperties implementation for registering ...
4 years, 7 months ago (2016-05-05 20:55:31 UTC) #8
halliwell
thakis: PTAL at chrome/ pfeldman: PTAL at content/
4 years, 7 months ago (2016-05-05 21:01:28 UTC) #10
Nico
chrome/ lgtm
4 years, 7 months ago (2016-05-05 21:02:48 UTC) #11
halliwell
https://codereview.chromium.org/1953803002/diff/1/chrome/renderer/media/chrome_key_systems.cc File chrome/renderer/media/chrome_key_systems.cc (right): https://codereview.chromium.org/1953803002/diff/1/chrome/renderer/media/chrome_key_systems.cc#newcode60 chrome/renderer/media/chrome_key_systems.cc:60: // KeySystemProperties implementation for registering external ClearKey systems. On ...
4 years, 7 months ago (2016-05-05 22:44:11 UTC) #12
pfeldman
content/ lgtm
4 years, 7 months ago (2016-05-07 00:29:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953803002/20001
4 years, 7 months ago (2016-05-07 00:30:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223747)
4 years, 7 months ago (2016-05-07 01:40:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953803002/20001
4 years, 7 months ago (2016-05-09 15:13:26 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 16:28:08 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 16:29:30 UTC) #24
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d81cefb589e700ab30d1d951ca1294bd50ed3519
Cr-Commit-Position: refs/heads/master@{#392329}

Powered by Google App Engine
This is Rietveld 408576698