Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1953773002: Forward declare CT structs in ct_serialization.h (Closed)

Created:
4 years, 7 months ago by Rob Percival
Modified:
4 years, 7 months ago
Reviewers:
eroman, Eran Messeri
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward declare CT structs in ct_serialization.h Also include what you use in ct_serialization.h. BUG=608868 Committed: https://crrev.com/f520475a947e34407e89844d5889967e66928165 Cr-Commit-Position: refs/heads/master@{#392260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M net/cert/ct_serialization.h View 2 chunks +7 lines, -2 lines 0 comments Download
M net/cert/ct_serialization.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/cert/ct_serialization_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Rob Percival
4 years, 7 months ago (2016-05-05 17:03:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953773002/1
4 years, 7 months ago (2016-05-05 17:59:08 UTC) #4
Eran Messeri
lgtm
4 years, 7 months ago (2016-05-05 20:02:48 UTC) #5
Rob Percival
4 years, 7 months ago (2016-05-05 20:05:45 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 21:25:08 UTC) #9
eroman
lgtm
4 years, 7 months ago (2016-05-06 23:35:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953773002/1
4 years, 7 months ago (2016-05-07 13:01:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-07 14:19:45 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 14:20:41 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f520475a947e34407e89844d5889967e66928165
Cr-Commit-Position: refs/heads/master@{#392260}

Powered by Google App Engine
This is Rietveld 408576698