Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/gpu/arc_gpu_video_decode_accelerator.h

Issue 1953683002: Add stride for imported Dmabuf in ArcVideoAccelerator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/gpu/arc_gpu_video_decode_accelerator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_GPU_ARC_GPU_VIDEO_DECODE_ACCELERATOR_H_ 5 #ifndef CHROME_GPU_ARC_GPU_VIDEO_DECODE_ACCELERATOR_H_
6 #define CHROME_GPU_ARC_GPU_VIDEO_DECODE_ACCELERATOR_H_ 6 #define CHROME_GPU_ARC_GPU_VIDEO_DECODE_ACCELERATOR_H_
7 7
8 #include <list> 8 #include <list>
9 #include <memory> 9 #include <memory>
10 #include <queue> 10 #include <queue>
(...skipping 24 matching lines...) Expand all
35 bool Initialize(const Config& config, 35 bool Initialize(const Config& config,
36 ArcVideoAccelerator::Client* client) override; 36 ArcVideoAccelerator::Client* client) override;
37 void SetNumberOfOutputBuffers(size_t number) override; 37 void SetNumberOfOutputBuffers(size_t number) override;
38 void BindSharedMemory(PortType port, 38 void BindSharedMemory(PortType port,
39 uint32_t index, 39 uint32_t index,
40 base::ScopedFD ashmem_fd, 40 base::ScopedFD ashmem_fd,
41 off_t offset, 41 off_t offset,
42 size_t length) override; 42 size_t length) override;
43 void BindDmabuf(PortType port, 43 void BindDmabuf(PortType port,
44 uint32_t index, 44 uint32_t index,
45 base::ScopedFD dmabuf_fd) override; 45 base::ScopedFD dmabuf_fd,
46 int32_t stride) override;
46 void UseBuffer(PortType port, 47 void UseBuffer(PortType port,
47 uint32_t index, 48 uint32_t index,
48 const BufferMetadata& metadata) override; 49 const BufferMetadata& metadata) override;
49 void Reset() override; 50 void Reset() override;
50 51
51 // Implementation of the VideoDecodeAccelerator::Client interface. 52 // Implementation of the VideoDecodeAccelerator::Client interface.
52 void ProvidePictureBuffers(uint32_t requested_num_of_buffers, 53 void ProvidePictureBuffers(uint32_t requested_num_of_buffers,
53 uint32_t textures_per_buffer, 54 uint32_t textures_per_buffer,
54 const gfx::Size& dimensions, 55 const gfx::Size& dimensions,
55 uint32_t texture_target) override; 56 uint32_t texture_target) override;
(...skipping 15 matching lines...) Expand all
71 InputRecord(int32_t bitstream_buffer_id, 72 InputRecord(int32_t bitstream_buffer_id,
72 uint32_t buffer_index, 73 uint32_t buffer_index,
73 int64_t timestamp); 74 int64_t timestamp);
74 }; 75 };
75 76
76 // The information about the shared memory used as an input buffer. 77 // The information about the shared memory used as an input buffer.
77 struct InputBufferInfo { 78 struct InputBufferInfo {
78 // The file handle to access the buffer. It is owned by this class and 79 // The file handle to access the buffer. It is owned by this class and
79 // should be closed after use. 80 // should be closed after use.
80 base::ScopedFD handle; 81 base::ScopedFD handle;
81 off_t offset; 82
82 size_t length; 83 // The offset of the payload to the beginning of the shared memory.
84 off_t offset = 0;
85
86 // The length of the payload.
Pawel Osciak 2016/05/11 01:53:57 size of the payload in bytes.
87 size_t length = 0;
83 88
84 InputBufferInfo(); 89 InputBufferInfo();
85 InputBufferInfo(InputBufferInfo&& other); 90 InputBufferInfo(InputBufferInfo&& other);
86 ~InputBufferInfo(); 91 ~InputBufferInfo();
87 }; 92 };
88 93
94 // The information about the dmabuf used as an output buffer.
95 struct OutputBufferInfo {
96 base::ScopedFD handle;
97 int32_t stride = 0; // In bytes.
98
99 OutputBufferInfo();
100 OutputBufferInfo(OutputBufferInfo&& other);
101 ~OutputBufferInfo();
102 };
103
89 // Helper function to Send the end-of-stream output buffer if 104 // Helper function to Send the end-of-stream output buffer if
90 // |pending_eos_output_buffer_| is true, or reuse the picture in ArcVDA. 105 // |pending_eos_output_buffer_| is true, or reuse the picture in ArcVDA.
91 void SendEosIfNeededOrReusePicture(uint32_t index); 106 void SendEosIfNeededOrReusePicture(uint32_t index);
92 107
93 // Helper function to validate |port| and |index|. 108 // Helper function to validate |port| and |index|.
94 bool ValidatePortAndIndex(PortType port, uint32_t index); 109 bool ValidatePortAndIndex(PortType port, uint32_t index);
95 110
96 // Creates an InputRecord for the given |bitstream_buffer_id|. The 111 // Creates an InputRecord for the given |bitstream_buffer_id|. The
97 // |buffer_index| is the index of the associated input buffer. The |timestamp| 112 // |buffer_index| is the index of the associated input buffer. The |timestamp|
98 // is the time the video frame should be displayed. 113 // is the time the video frame should be displayed.
(...skipping 27 matching lines...) Expand all
126 // to VDA for reuse. 141 // to VDA for reuse.
127 std::queue<int32_t> buffers_pending_eos_; 142 std::queue<int32_t> buffers_pending_eos_;
128 143
129 // A list of most recent |kMaxNumberOfInputRecord| InputRecords. 144 // A list of most recent |kMaxNumberOfInputRecord| InputRecords.
130 // |kMaxNumberOfInputRecord| is defined in the cc file. 145 // |kMaxNumberOfInputRecord| is defined in the cc file.
131 std::list<InputRecord> input_records_; 146 std::list<InputRecord> input_records_;
132 147
133 // The details of the shared memory of each input buffers. 148 // The details of the shared memory of each input buffers.
134 std::vector<InputBufferInfo> input_buffer_info_; 149 std::vector<InputBufferInfo> input_buffer_info_;
135 150
136 // To keep those output buffers which have been bound by bindDmabuf() but not 151 // To keep those output buffers which have been bound by bindDmabuf() but
137 // be used yet. Will call VDA::ImportBufferForPicture() when those buffers are 152 // haven't been passed to VDA yet. Will call VDA::ImportBufferForPicture()
138 // used for the first time. 153 // when those buffers are used for the first time.
139 std::vector<base::ScopedFD> buffers_pending_import_; 154 std::vector<OutputBufferInfo> buffers_pending_import_;
140 155
141 base::ThreadChecker thread_checker_; 156 base::ThreadChecker thread_checker_;
142 size_t output_buffer_size_; 157 size_t output_buffer_size_;
143 158
144 gpu::GpuPreferences gpu_preferences_; 159 gpu::GpuPreferences gpu_preferences_;
145 160
146 DISALLOW_COPY_AND_ASSIGN(ArcGpuVideoDecodeAccelerator); 161 DISALLOW_COPY_AND_ASSIGN(ArcGpuVideoDecodeAccelerator);
147 }; 162 };
148 163
149 } // namespace arc 164 } // namespace arc
150 } // namespace chromeos 165 } // namespace chromeos
151 166
152 #endif // CHROME_GPU_ARC_GPU_VIDEO_DECODE_ACCELERATOR_H_ 167 #endif // CHROME_GPU_ARC_GPU_VIDEO_DECODE_ACCELERATOR_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/gpu/arc_gpu_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698