Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1953673004: Remove unnecessary full GCs before snapshot creation. (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unnecessary full GCs before snapshot creation. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/e0184aa8237e2dacf5f275f5a4ebb269f1ad926f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M runtime/vm/dart_api_impl.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 7 months ago (2016-05-05 22:15:21 UTC) #2
siva
lgtm
4 years, 7 months ago (2016-05-05 22:36:15 UTC) #3
rmacnak
4 years, 7 months ago (2016-05-05 22:55:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0184aa8237e2dacf5f275f5a4ebb269f1ad926f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698