Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1953673002: [Media Router WebUI] Fix search input and issue overlap. (Closed)

Created:
4 years, 7 months ago by btolsch
Modified:
4 years, 7 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix search input and issue overlap. This change prevents the search input from overlapping non-blocking issues by positioning the search input relative to its direct parent. BUG=609351 R=apacible@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d8983fb03e941fb937b8ede5c18ac7e54d5564d2 Cr-Commit-Position: refs/heads/master@{#391875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
btolsch
I linked screenshots with a non-blocking issue and no devices (since that case was also ...
4 years, 7 months ago (2016-05-05 02:31:53 UTC) #2
apacible
lgtm
4 years, 7 months ago (2016-05-05 17:29:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953673002/1
4 years, 7 months ago (2016-05-05 18:08:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 19:43:20 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 19:45:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8983fb03e941fb937b8ede5c18ac7e54d5564d2
Cr-Commit-Position: refs/heads/master@{#391875}

Powered by Google App Engine
This is Rietveld 408576698