Source/core/rendering/RenderBlock.h - Issue 195363007: Avoid unnecessary descents into nested boxes with floats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.h

Issue 195363007: Avoid unnecessary descents into nested boxes with floats. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/block/float/float-mark-descendants-for-layout-crash.html ('K') | « LayoutTests/fast/block/float/float-mark-descendants-for-layout-crash-expected.txt ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.h

diff --git a/Source/core/rendering/RenderBlock.h b/Source/core/rendering/RenderBlock.h

index 20563662e6d944b7954452c4a0560233d61f6a11..4f0cd2906e728ce665c7bd2bf87a66dc997ee6b7 100644

--- a/Source/core/rendering/RenderBlock.h

+++ b/Source/core/rendering/RenderBlock.h

@@ -531,13 +531,14 @@ protected:

RenderObjectChildList m_children;

RenderLineBoxList m_lineBoxes; // All of the root line boxes created for this block flow. For example, <div>Hello<br>world.</div> will have two total lines for the <div>.

- mutable signed m_lineHeight : 26;

+ mutable signed m_lineHeight : 25;

pdr. 2014/04/26 01:47:41 Can you help me understand why this change from 26

unsigned m_hasMarginBeforeQuirk : 1; // Note these quirk values can't be put in RenderBlockRareData since they are set too frequently.

unsigned m_hasMarginAfterQuirk : 1;

unsigned m_beingDestroyed : 1;

unsigned m_hasMarkupTruncation : 1;

unsigned m_hasBorderOrPaddingLogicalWidthChanged : 1;

mutable unsigned m_hasOnlySelfCollapsingChildren : 1;

+ mutable unsigned m_descendantsWithFloatsMarkedForLayout : 1;

// RenderRubyBase objects need to be able to split and merge, moving their children around

// (calling moveChildTo, moveAllChildrenTo, and makeChildrenNonInline).