Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/a64/macro-assembler-a64.cc

Issue 195363003: A64: Tidy up a few TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/macro-assembler-a64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1740 matching lines...) Expand 10 before | Expand all | Expand 10 after
1751 Builtins::JavaScript id) { 1751 Builtins::JavaScript id) {
1752 // Load the builtins object into target register. 1752 // Load the builtins object into target register.
1753 Ldr(target, GlobalObjectMemOperand()); 1753 Ldr(target, GlobalObjectMemOperand());
1754 Ldr(target, FieldMemOperand(target, GlobalObject::kBuiltinsOffset)); 1754 Ldr(target, FieldMemOperand(target, GlobalObject::kBuiltinsOffset));
1755 // Load the JavaScript builtin function from the builtins object. 1755 // Load the JavaScript builtin function from the builtins object.
1756 Ldr(target, FieldMemOperand(target, 1756 Ldr(target, FieldMemOperand(target,
1757 JSBuiltinsObject::OffsetOfFunctionWithId(id))); 1757 JSBuiltinsObject::OffsetOfFunctionWithId(id)));
1758 } 1758 }
1759 1759
1760 1760
1761 void MacroAssembler::GetBuiltinEntry(Register target, Builtins::JavaScript id) { 1761 void MacroAssembler::GetBuiltinEntry(Register target,
1762 ASSERT(!target.is(x1)); 1762 Register function,
1763 GetBuiltinFunction(x1, id); 1763 Builtins::JavaScript id) {
1764 ASSERT(!AreAliased(target, function));
1765 GetBuiltinFunction(function, id);
1764 // Load the code entry point from the builtins object. 1766 // Load the code entry point from the builtins object.
1765 Ldr(target, FieldMemOperand(x1, JSFunction::kCodeEntryOffset)); 1767 Ldr(target, FieldMemOperand(function, JSFunction::kCodeEntryOffset));
1766 } 1768 }
1767 1769
1768 1770
1769 void MacroAssembler::InvokeBuiltin(Builtins::JavaScript id, 1771 void MacroAssembler::InvokeBuiltin(Builtins::JavaScript id,
1770 InvokeFlag flag, 1772 InvokeFlag flag,
1771 const CallWrapper& call_wrapper) { 1773 const CallWrapper& call_wrapper) {
1772 ASM_LOCATION("MacroAssembler::InvokeBuiltin"); 1774 ASM_LOCATION("MacroAssembler::InvokeBuiltin");
1773 // You can't call a builtin without a valid frame. 1775 // You can't call a builtin without a valid frame.
1774 ASSERT(flag == JUMP_FUNCTION || has_frame()); 1776 ASSERT(flag == JUMP_FUNCTION || has_frame());
1775 1777
1776 GetBuiltinEntry(x2, id); 1778 // Get the builtin entry in x2 and setup the function object in x1.
1779 GetBuiltinEntry(x2, x1, id);
1777 if (flag == CALL_FUNCTION) { 1780 if (flag == CALL_FUNCTION) {
1778 call_wrapper.BeforeCall(CallSize(x2)); 1781 call_wrapper.BeforeCall(CallSize(x2));
1779 Call(x2); 1782 Call(x2);
1780 call_wrapper.AfterCall(); 1783 call_wrapper.AfterCall();
1781 } else { 1784 } else {
1782 ASSERT(flag == JUMP_FUNCTION); 1785 ASSERT(flag == JUMP_FUNCTION);
1783 Jump(x2); 1786 Jump(x2);
1784 } 1787 }
1785 } 1788 }
1786 1789
(...skipping 3318 matching lines...) Expand 10 before | Expand all | Expand 10 after
5105 } 5108 }
5106 } 5109 }
5107 5110
5108 5111
5109 #undef __ 5112 #undef __
5110 5113
5111 5114
5112 } } // namespace v8::internal 5115 } } // namespace v8::internal
5113 5116
5114 #endif // V8_TARGET_ARCH_A64 5117 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « src/a64/macro-assembler-a64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698