Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: src/a64/assembler-a64.h

Issue 195363003: A64: Tidy up a few TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/macro-assembler-a64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 828 matching lines...) Expand 10 before | Expand all | Expand 10 after
839 ASSERT(size >= 0); 839 ASSERT(size >= 0);
840 ASSERT(static_cast<uint64_t>(size) == SizeOfCodeGeneratedSince(label)); 840 ASSERT(static_cast<uint64_t>(size) == SizeOfCodeGeneratedSince(label));
841 } 841 }
842 842
843 // Return the number of instructions generated from label to the 843 // Return the number of instructions generated from label to the
844 // current position. 844 // current position.
845 int InstructionsGeneratedSince(const Label* label) { 845 int InstructionsGeneratedSince(const Label* label) {
846 return SizeOfCodeGeneratedSince(label) / kInstructionSize; 846 return SizeOfCodeGeneratedSince(label) / kInstructionSize;
847 } 847 }
848 848
849 // TODO(all): Initialize these constants related with code patching.
850 // TODO(all): Set to -1 to hopefully crash if mistakenly used.
851
852 // Number of instructions generated for the return sequence in 849 // Number of instructions generated for the return sequence in
853 // FullCodeGenerator::EmitReturnSequence. 850 // FullCodeGenerator::EmitReturnSequence.
854 static const int kJSRetSequenceInstructions = 7; 851 static const int kJSRetSequenceInstructions = 7;
855 // Distance between start of patched return sequence and the emitted address 852 // Distance between start of patched return sequence and the emitted address
856 // to jump to. 853 // to jump to.
857 static const int kPatchReturnSequenceAddressOffset = 0; 854 static const int kPatchReturnSequenceAddressOffset = 0;
858 static const int kPatchDebugBreakSlotAddressOffset = 0; 855 static const int kPatchDebugBreakSlotAddressOffset = 0;
859 856
860 // Number of instructions necessary to be able to later patch it to a call. 857 // Number of instructions necessary to be able to later patch it to a call.
861 // See Debug::GenerateSlot() and BreakLocationIterator::SetDebugBreakAtSlot(). 858 // See Debug::GenerateSlot() and BreakLocationIterator::SetDebugBreakAtSlot().
(...skipping 1330 matching lines...) Expand 10 before | Expand all | Expand 10 after
2192 class EnsureSpace BASE_EMBEDDED { 2189 class EnsureSpace BASE_EMBEDDED {
2193 public: 2190 public:
2194 explicit EnsureSpace(Assembler* assembler) { 2191 explicit EnsureSpace(Assembler* assembler) {
2195 assembler->CheckBuffer(); 2192 assembler->CheckBuffer();
2196 } 2193 }
2197 }; 2194 };
2198 2195
2199 } } // namespace v8::internal 2196 } } // namespace v8::internal
2200 2197
2201 #endif // V8_A64_ASSEMBLER_A64_H_ 2198 #endif // V8_A64_ASSEMBLER_A64_H_
OLDNEW
« no previous file with comments | « no previous file | src/a64/macro-assembler-a64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698