Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Issue 1953623002: Clean up multisampled color mask workaround for DrawingBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp40_drawingbuffer_cleanup
Patch Set: Comments from kbr and fix up a conditional. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
index c36a9ea2e8494ca01251b042b1bbabed31b8010d..4577dedfd968db3b815c31e646ad7ceb046b5bdf 100644
--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
@@ -243,7 +243,6 @@ private:
// emulation is required.
GLenum creationInternalColorFormat = 0;
GLenum colorFormat = 0;
- GLenum internalRenderbufferFormat = 0;
};
// If we used CHROMIUM_image as the backing storage for our buffers,
@@ -348,6 +347,13 @@ private:
// Whether the WebGL client wants a depth or stencil buffer.
bool wantDepthOrStencil();
+ // The format to use when creating a multisampled renderbuffer.
+ GLenum getMultisampledRenderbufferFormat();
+
+ // Similar to requiresAlphaChannelToBePreserved(), but always targets the
+ // default framebuffer.
+ bool defaultBufferRequiresAlphaChannelToBePreserved();
+
const PreserveDrawingBuffer m_preserveDrawingBuffer;
bool m_scissorEnabled = false;
GLuint m_texture2DBinding = 0;
@@ -378,19 +384,15 @@ private:
// This is used when the user requests either a depth or stencil buffer.
GLuint m_depthStencilBuffer = 0;
- // For explicit resolve.
- GLuint m_intermediateFBO = 0;
- GLuint m_intermediateRenderbuffer = 0;
-
- // When wantsExplicitResolve() returns true, the target of all draw
+ // When wantExplicitResolve() returns true, the target of all draw
// operations.
GLuint m_multisampleFBO = 0;
// The id of the renderbuffer storage for |m_multisampleFBO|.
GLuint m_multisampleRenderbuffer = 0;
- // When wantsExplicitResolve() returns false, the target of all draw and
- // read operations. When wantsExplicitResolve() returns true, the target of
+ // When wantExplicitResolve() returns false, the target of all draw and
+ // read operations. When wantExplicitResolve() returns true, the target of
// all read operations. A swap is performed by exchanging |m_colorBuffer|
// with |m_frontColorBuffer|.
GLuint m_fbo = 0;
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698