content/browser/devtools/DEPS - Issue 1953593002: Move DevToolsNetLogObserver to c/b/loader and create stub of network service interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/devtools/DEPS

Issue 1953593002: Move DevToolsNetLogObserver to c/b/loader and create stub of network service interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Generated by the local devtools_resources.gyp:devtools_resources	2 # Generated by the local devtools_resources.gyp:devtools_resources

3 "+grit/devtools_resources_map.h",	3 "+grit/devtools_resources_map.h",

	4

	5 # content/browser/loader is being separated out into a service. For more

	6 # information, see https://crbug.com/598073.

	7 "-content/browser/loader",
	jam 2016/05/05 16:06:07 as a precursor for moving loading code out to serv as a precursor for moving loading code out to services/network, we need the code that will move to not include stuff from content. we don't necessarily need code in content to only access the code that will be moved via interfaces. that would add extra work for us to add wrappers. wdyt? scottmg 2016/05/05 16:53:02 You mean just move it, but have content including Show quoted text On 2016/05/05 16:06:07, jam wrote: > as a precursor for moving loading code out to services/network, we need the code > that will move to not include stuff from content. > > we don't necessarily need code in content to only access the code that will be > moved via interfaces. that would add extra work for us to add wrappers. wdyt? You mean just move it, but have content including things from content/browser/loader still? I guess we could do that, but we're not going to want content including things from //services/network, right? So you just want to do it in two phases instead?
	8 "+content/browser/loader/network_service_interface.h",

4 ]	9 ]

OLD	NEW

« no previous file with comments | « no previous file | content/browser/devtools/devtools_manager.cc » ('j') | no next file with comments »