Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1953543002: Rename WebAPK related classes to be of the format *WebApk*.java (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, mlamouri+watch-notifications_chromium.org, jam, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WebAPK related classes to be of the format *WebApk*.java BUG=609488

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -935 lines) Patch
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/PackageReveiver.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 6 chunks +13 lines, -13 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 4 chunks +7 lines, -7 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M web_apks/minting_example/AndroidManifest.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M web_apks/minting_example/BUILD.gn View 5 chunks +9 lines, -9 lines 0 comments Download
M web_apks/minting_example/javatests/src/org/chromium/minting/DexLoaderTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
D web_apks/minting_example/junit/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/MintedServiceImplTest.java View 1 chunk +0 lines, -100 lines 0 comments Download
A + web_apks/minting_example/junit/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/WebApkServiceImplTest.java View 4 chunks +10 lines, -10 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/MintingStateParams.java View 1 chunk +0 lines, -46 lines 0 comments Download
M web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NavigationClient.java View 3 chunks +4 lines, -4 lines 0 comments Download
M web_apks/minting_example/libs/client/org/chromium/minting/lib/client/NotificationClient.java View 4 chunks +4 lines, -4 lines 0 comments Download
D web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebAPKValidator.java View 1 chunk +0 lines, -122 lines 0 comments Download
A + web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebApkStateParams.java View 1 chunk +3 lines, -3 lines 0 comments Download
A + web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebApkValidator.java View 3 chunks +4 lines, -4 lines 0 comments Download
M web_apks/minting_example/libs/client/org/chromium/minting/lib/client/WebApkVersionManager.java View 2 chunks +2 lines, -2 lines 0 comments Download
D web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebAPKConstants.java View 1 chunk +0 lines, -16 lines 0 comments Download
D web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebAPKUtils.java View 1 chunk +0 lines, -71 lines 0 comments Download
A + web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebApkConstants.java View 1 chunk +1 line, -1 line 0 comments Download
A + web_apks/minting_example/libs/common/org/chromium/minting/lib/common/WebApkUtils.java View 1 chunk +1 line, -1 line 0 comments Download
D web_apks/minting_example/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/IMintedApi.aidl View 1 chunk +0 lines, -27 lines 0 comments Download
A + web_apks/minting_example/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/IWebApkApi.aidl View 1 chunk +1 line, -1 line 0 comments Download
D web_apks/minting_example/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/MintedServiceImpl.java View 1 chunk +0 lines, -98 lines 0 comments Download
A + web_apks/minting_example/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/WebApkServiceImpl.java View 2 chunks +3 lines, -3 lines 0 comments Download
M web_apks/minting_example/libs/runtime_library/src/org/chromium/minting/libs/runtime_library/common.aidl View 1 chunk +1 line, -1 line 0 comments Download
M web_apks/minting_example/src/org/chromium/minting/MainActivity.java View 4 chunks +4 lines, -7 lines 0 comments Download
D web_apks/minting_example/src/org/chromium/minting/MintingApplication.java View 1 chunk +0 lines, -156 lines 0 comments Download
D web_apks/minting_example/src/org/chromium/minting/MintingServiceFactory.java View 1 chunk +0 lines, -168 lines 0 comments Download
A + web_apks/minting_example/src/org/chromium/minting/WebApkApplication.java View 3 chunks +4 lines, -5 lines 0 comments Download
A + web_apks/minting_example/src/org/chromium/minting/WebApkServiceFactory.java View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pkotwicz
Xi can you please take a look? I did "find and replace" accross an entire ...
4 years, 7 months ago (2016-05-04 20:08:11 UTC) #2
Xi Han
This is awesome! Thank you Peter! I use git gs "WebAPK" and find something else ...
4 years, 7 months ago (2016-05-04 21:29:24 UTC) #3
pkotwicz
4 years, 7 months ago (2016-05-05 17:01:21 UTC) #5 
Thank you for the code review. I know that I still need to fix up the "WebAPK"
naming in function names, variable names and comments. One thing at a time :)

Powered by Google App Engine
This is Rietveld 408576698