Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: base/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/BUILD.gn ('k') | breakpad/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 56266feccb94502d580f9517991cf8105d019b49..17d90ca76b7891e96fdd279388cfe5c932a7bac7 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1528,65 +1528,62 @@ component("i18n") {
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
-if (is_ios || is_android || is_win || (is_linux && !is_chromeos)) {
- # TODO(GYP): Figure out which of these work and are needed on other platforms.
- test("base_perftests") {
- sources = [
- "message_loop/message_pump_perftest.cc",
+test("base_perftests") {
+ sources = [
+ "message_loop/message_pump_perftest.cc",
+
+ # "test/run_all_unittests.cc",
+ "threading/thread_perftest.cc",
+ ]
+ deps = [
+ ":base",
+ "//base/test:test_support",
+ "//base/test:test_support_perf",
+ "//testing/gtest",
+ "//testing/perf",
+ ]
+
+ if (is_android) {
+ deps += [ "//testing/android/native_test:native_test_native_code" ]
+ }
+}
+
+test("base_i18n_perftests") {
+ sources = [
+ "i18n/streaming_utf8_validator_perftest.cc",
+ ]
+ deps = [
+ ":base",
+ ":i18n",
+ "//base/test:test_support",
+ "//base/test:test_support_perf",
+ "//testing/gtest",
+ ]
+}
- # "test/run_all_unittests.cc",
- "threading/thread_perftest.cc",
+if (!is_ios) {
+ executable("build_utf8_validator_tables") {
+ sources = [
+ "i18n/build_utf8_validator_tables.cc",
]
deps = [
":base",
- "//base/test:test_support",
- "//base/test:test_support_perf",
- "//testing/gtest",
- "//testing/perf",
+ "//build/config/sanitizers:deps",
+ "//build/win:default_exe_manifest",
+ "//third_party/icu:icuuc",
]
-
- if (is_android) {
- deps += [ "//testing/android/native_test:native_test_native_code" ]
- }
}
- test("base_i18n_perftests") {
+ executable("check_example") {
sources = [
- "i18n/streaming_utf8_validator_perftest.cc",
+ "check_example.cc",
]
deps = [
":base",
- ":i18n",
- "//base/test:test_support",
- "//base/test:test_support_perf",
- "//testing/gtest",
+ "//build/config/sanitizers:deps",
+ "//build/win:default_exe_manifest",
]
}
-
- if (!is_ios) {
- executable("build_utf8_validator_tables") {
- sources = [
- "i18n/build_utf8_validator_tables.cc",
- ]
- deps = [
- ":base",
- "//build/config/sanitizers:deps",
- "//build/win:default_exe_manifest",
- "//third_party/icu:icuuc",
- ]
- }
-
- executable("check_example") {
- sources = [
- "check_example.cc",
- ]
- deps = [
- ":base",
- "//build/config/sanitizers:deps",
- "//build/win:default_exe_manifest",
- ]
- }
- }
}
source_set("message_loop_tests") {
« no previous file with comments | « ash/BUILD.gn ('k') | breakpad/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698