Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 "app/main_dll_loader_win.cc", 112 "app/main_dll_loader_win.cc",
113 "app/main_dll_loader_win.h", 113 "app/main_dll_loader_win.h",
114 "common/crash_keys.cc", 114 "common/crash_keys.cc",
115 "common/crash_keys.h", 115 "common/crash_keys.h",
116 ] 116 ]
117 117
118 deps += [ 118 deps += [
119 ":chrome_dll", 119 ":chrome_dll",
120 ":chrome_exe_version", 120 ":chrome_exe_version",
121 ":file_pre_reader", 121 ":file_pre_reader",
122
123 # 'chrome_nacl_win64" TODO(GYP) bug 512869
124 "//base", 122 "//base",
125 "//breakpad:breakpad_handler", 123 "//breakpad:breakpad_handler",
126 "//breakpad:breakpad_sender", 124 "//breakpad:breakpad_sender",
127 "//chrome/app/version_assembly:chrome_exe_manifest", 125 "//chrome/app/version_assembly:chrome_exe_manifest",
128 "//chrome/browser:chrome_process_finder", 126 "//chrome/browser:chrome_process_finder",
129 "//chrome/chrome_watcher", 127 "//chrome/chrome_watcher",
130 "//chrome/chrome_watcher:client", 128 "//chrome/chrome_watcher:client",
131 "//chrome/common:constants", 129 "//chrome/common:constants",
132 "//chrome/common:metrics_constants_util_win", 130 "//chrome/common:metrics_constants_util_win",
133 "//chrome/installer/util:with_no_strings", 131 "//chrome/installer/util:with_no_strings",
(...skipping 1213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1347 inputs = [ 1345 inputs = [
1348 chrome_binary, 1346 chrome_binary,
1349 dump_syms_binary, 1347 dump_syms_binary,
1350 ] 1348 ]
1351 outputs = [ 1349 outputs = [
1352 symbol_file, 1350 symbol_file,
1353 ] 1351 ]
1354 1352
1355 args = [ 1353 args = [
1356 "./" + rebase_path(dump_syms_binary, root_build_dir), 1354 "./" + rebase_path(dump_syms_binary, root_build_dir),
1357 "0", # TODO(GYP) This is linux_strip_binary if it is needed. 1355 "0", # strip_binary = false
1358 rebase_path(chrome_binary, root_build_dir), 1356 rebase_path(chrome_binary, root_build_dir),
1359 rebase_path(symbol_file, root_build_dir), 1357 rebase_path(symbol_file, root_build_dir),
1360 ] 1358 ]
1361 1359
1362 deps = [ 1360 deps = [
1363 ":chrome", 1361 ":chrome",
1364 dump_syms_label, 1362 dump_syms_label,
1365 ] 1363 ]
1366 } 1364 }
1367 } 1365 }
1368 1366
1369 # Copies some scripts and resources that are used for desktop integration. 1367 # Copies some scripts and resources that are used for desktop integration.
1370 copy("xdg_mime") { 1368 copy("xdg_mime") {
1371 sources = [ 1369 sources = [
1372 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1370 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1373 "//chrome/tools/build/linux/chrome-wrapper", 1371 "//chrome/tools/build/linux/chrome-wrapper",
1374 "//third_party/xdg-utils/scripts/xdg-mime", 1372 "//third_party/xdg-utils/scripts/xdg-mime",
1375 "//third_party/xdg-utils/scripts/xdg-settings", 1373 "//third_party/xdg-utils/scripts/xdg-settings",
1376 ] 1374 ]
1377 outputs = [ 1375 outputs = [
1378 "$root_out_dir/{{source_file_part}}", 1376 "$root_out_dir/{{source_file_part}}",
1379 ] 1377 ]
1380 } 1378 }
1381 } 1379 }
OLDNEW
« no previous file with comments | « cc/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698