Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 "app/main_dll_loader_win.cc", 124 "app/main_dll_loader_win.cc",
125 "app/main_dll_loader_win.h", 125 "app/main_dll_loader_win.h",
126 "common/crash_keys.cc", 126 "common/crash_keys.cc",
127 "common/crash_keys.h", 127 "common/crash_keys.h",
128 ] 128 ]
129 129
130 deps += [ 130 deps += [
131 ":chrome_dll", 131 ":chrome_dll",
132 ":chrome_exe_version", 132 ":chrome_exe_version",
133 ":file_pre_reader", 133 ":file_pre_reader",
134
135 # 'chrome_nacl_win64" TODO(GYP) bug 512869
brettw 2016/05/04 19:51:28 This is nacl64.exe which gets build inside of nati
136 "//base", 134 "//base",
137 "//breakpad:breakpad_handler", 135 "//breakpad:breakpad_handler",
138 "//breakpad:breakpad_sender", 136 "//breakpad:breakpad_sender",
139 "//chrome/app/version_assembly:chrome_exe_manifest", 137 "//chrome/app/version_assembly:chrome_exe_manifest",
140 "//chrome/browser:chrome_process_finder", 138 "//chrome/browser:chrome_process_finder",
141 "//chrome/chrome_watcher", 139 "//chrome/chrome_watcher",
142 "//chrome/chrome_watcher:client", 140 "//chrome/chrome_watcher:client",
143 "//chrome/common:constants", 141 "//chrome/common:constants",
144 "//chrome/common:metrics_constants_util_win", 142 "//chrome/common:metrics_constants_util_win",
145 "//chrome/installer/util:with_no_strings", 143 "//chrome/installer/util:with_no_strings",
(...skipping 1178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1324 inputs = [ 1322 inputs = [
1325 chrome_binary, 1323 chrome_binary,
1326 dump_syms_binary, 1324 dump_syms_binary,
1327 ] 1325 ]
1328 outputs = [ 1326 outputs = [
1329 symbol_file, 1327 symbol_file,
1330 ] 1328 ]
1331 1329
1332 args = [ 1330 args = [
1333 "./" + rebase_path(dump_syms_binary, root_build_dir), 1331 "./" + rebase_path(dump_syms_binary, root_build_dir),
1334 "0", # TODO(GYP) This is linux_strip_binary if it is needed. 1332 "0", # strip_binary = false
1335 rebase_path(chrome_binary, root_build_dir), 1333 rebase_path(chrome_binary, root_build_dir),
1336 rebase_path(symbol_file, root_build_dir), 1334 rebase_path(symbol_file, root_build_dir),
1337 ] 1335 ]
1338 1336
1339 deps = [ 1337 deps = [
1340 ":chrome", 1338 ":chrome",
1341 dump_syms_label, 1339 dump_syms_label,
1342 ] 1340 ]
1343 } 1341 }
1344 } 1342 }
1345 1343
1346 # Copies some scripts and resources that are used for desktop integration. 1344 # Copies some scripts and resources that are used for desktop integration.
1347 copy("xdg_mime") { 1345 copy("xdg_mime") {
1348 sources = [ 1346 sources = [
1349 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1347 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1350 "//chrome/tools/build/linux/chrome-wrapper", 1348 "//chrome/tools/build/linux/chrome-wrapper",
1351 "//third_party/xdg-utils/scripts/xdg-mime", 1349 "//third_party/xdg-utils/scripts/xdg-mime",
1352 "//third_party/xdg-utils/scripts/xdg-settings", 1350 "//third_party/xdg-utils/scripts/xdg-settings",
1353 ] 1351 ]
1354 outputs = [ 1352 outputs = [
1355 "$root_out_dir/{{source_file_part}}", 1353 "$root_out_dir/{{source_file_part}}",
1356 ] 1354 ]
1357 } 1355 }
1358 } 1356 }
OLDNEW
« build/gn_migration.gypi ('K') | « cc/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698