Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1953503002: Fixing a GYP include that caused ipc_mojo tests to be unintentionally built. (Closed)

Created:
4 years, 7 months ago by joedow
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing a GYP include that caused ipc_mojo tests to be unintentionally built. This change fixes a problem the CRD team is seeing on their private waterfall. The issue is that the ipc_mojo_unittests swarming target (added on April 29th) is now being built for a number of un-related targets (including ours which needs browser_tests to be built). I've tracked this down to a gypi file which included all targets from ipc_mojo. Changing this to only pull a specific target fixes the problem. BUG=609186 Committed: https://crrev.com/b1c45086462b022a93f97ba8c5baffa72660310a Cr-Commit-Position: refs/heads/master@{#391813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
joedow
Can you take a look at a GYP include change that fixes a problem on ...
4 years, 7 months ago (2016-05-04 18:42:04 UTC) #2
jam
lgtm
4 years, 7 months ago (2016-05-05 15:38:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953503002/1
4 years, 7 months ago (2016-05-05 15:54:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 15:58:19 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 15:59:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1c45086462b022a93f97ba8c5baffa72660310a
Cr-Commit-Position: refs/heads/master@{#391813}

Powered by Google App Engine
This is Rietveld 408576698