Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1953493002: Mojo C++ bindings: custom type mapping for array - part 2 (Closed)

Created:
4 years, 7 months ago by yzshen1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@21_simplify
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: custom type mapping for array - part 2 This CL: - switches array and map to use the new serialization API. - gets rid of two layers of indirection: ArraySerializationStrategy and ArraySerializationImpl. - gets rid of wtf_array_serialization. - simplifies map serialization by reusing more of the array serialization logic. BUG=577686 Committed: https://crrev.com/c8c4b08746630b7a551cc685ff6ee425c1943e3b Cr-Commit-Position: refs/heads/master@{#392159}

Patch Set 1 #

Patch Set 2 : sync & resolve #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : convert map serialization #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+642 lines, -993 lines) Patch
M mojo/mojo_public.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 1 2 3 4 1 chunk +382 lines, -26 lines 0 comments Download
D mojo/public/cpp/bindings/lib/array_serialization_traits.h View 1 chunk +0 lines, -522 lines 0 comments Download
M mojo/public/cpp/bindings/lib/map_serialization.h View 1 2 3 4 5 6 1 chunk +90 lines, -170 lines 0 comments Download
M mojo/public/cpp/bindings/lib/native_struct_serialization.h View 1 2 3 4 4 chunks +4 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/lib/serialization_forward.h View 1 2 3 4 5 3 chunks +4 lines, -83 lines 0 comments Download
M mojo/public/cpp/bindings/lib/serialization_util.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
D mojo/public/cpp/bindings/lib/wtf_array_serialization.h View 1 chunk +0 lines, -45 lines 0 comments Download
M mojo/public/cpp/bindings/lib/wtf_serialization.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/map.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/array_common_test.h View 6 chunks +25 lines, -15 lines 0 comments Download
M mojo/public/cpp/bindings/tests/map_unittest.cc View 1 2 3 4 2 chunks +16 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/union_unittest.cc View 1 2 3 4 13 chunks +51 lines, -32 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 2 3 4 2 chunks +20 lines, -40 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 1 2 3 4 4 chunks +9 lines, -11 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 1 2 3 4 5 chunks +19 lines, -13 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 7 months ago (2016-05-04 18:50:01 UTC) #2
yzshen1
On 2016/05/04 18:50:01, yzshen1 wrote: > Hi, Ken. > > Would you please take a ...
4 years, 7 months ago (2016-05-04 21:34:44 UTC) #3
yzshen1
On 2016/05/04 21:34:44, yzshen1 wrote: > On 2016/05/04 18:50:01, yzshen1 wrote: > > Hi, Ken. ...
4 years, 7 months ago (2016-05-05 20:35:00 UTC) #5
Ken Rockot(use gerrit already)
lgtm!
4 years, 7 months ago (2016-05-06 20:13:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953493002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953493002/120001
4 years, 7 months ago (2016-05-06 20:24:34 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 7 months ago (2016-05-06 21:26:23 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 21:29:12 UTC) #12
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c8c4b08746630b7a551cc685ff6ee425c1943e3b
Cr-Commit-Position: refs/heads/master@{#392159}

Powered by Google App Engine
This is Rietveld 408576698