Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1953473002: Fix ASAN errors. (Closed)

Created:
4 years, 7 months ago by dogben
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, borenet, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix ASAN errors. These errors occur when building for GPU but running dm with --nogpu. The current ASAN bots do not catch these because 1) the CPU bot compiles with skia_gpu=0 and 2) the GPU bot runs with --nocpu; whereas the new ASAN bots use the same compile for both the CPU and GPU bots. BUG=skia:5157 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1953473002 Committed: https://skia.googlesource.com/skia/+/d9cca4a11a30f1391b56dd53ca2c6615298e2b14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/gpu/GrShape.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953473002/1
4 years, 7 months ago (2016-05-04 17:30:27 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 17:41:21 UTC) #6
dogben
4 years, 7 months ago (2016-05-04 17:43:15 UTC) #8
bsalomon
On 2016/05/04 17:43:15, Ben Wagner wrote: lgtm
4 years, 7 months ago (2016-05-04 17:44:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953473002/1
4 years, 7 months ago (2016-05-04 17:47:29 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:06:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d9cca4a11a30f1391b56dd53ca2c6615298e2b14

Powered by Google App Engine
This is Rietveld 408576698