content/renderer/media/webmediaplayer_impl.cc - Issue 19534002: Make RendererGpuVideoDecoderFactories live on arbitrary threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_impl.cc

Issue 19534002: Make RendererGpuVideoDecoderFactories live on arbitrary threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_dependency_factory.cc ('K') | « content/renderer/media/rtc_video_decoder_unittest.cc ('k') | content/renderer/render_thread_impl.h » ('j') | media/filters/gpu_video_decoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webmediaplayer_impl.cc

diff --git a/content/renderer/media/webmediaplayer_impl.cc b/content/renderer/media/webmediaplayer_impl.cc

index e760baf43c158cd22975ec127a84c8dafa22c5bc..53bee9e9989f477525ded6b532e4e597d4e1b036 100644

--- a/content/renderer/media/webmediaplayer_impl.cc

+++ b/content/renderer/media/webmediaplayer_impl.cc

@@ -1098,10 +1098,8 @@ void WebMediaPlayerImpl::StartPipeline(WebKit::WebMediaSource* media_source) {

// Create our video decoders and renderer.

ScopedVector<media::VideoDecoder> video_decoders;

- if (gpu_factories_.get()) {

- video_decoders.push_back(new media::GpuVideoDecoder(

- media_loop_, gpu_factories_));

- }

+ if (gpu_factories_.get())

+ video_decoders.push_back(new media::GpuVideoDecoder(gpu_factories_));

// TODO(phajdan.jr): Remove ifdefs when libvpx with vp9 support is released

// (http://crbug.com/174287) .