chrome/browser/task_management/task_manager_tester.h - Issue 1953383002: [Part 6 of 6] Move browsertests and utils to task_management/ directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/task_manager_tester.h

Issue 1953383002: [Part 6 of 6] Move browsertests and utils to task_management/ directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tm_file_split5

Patch Set: Comment fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_management/DEPS ('K') | « chrome/browser/task_management/task_manager_browsertest_util.cc ('k') | chrome/browser/task_manager/legacy_task_manager_tester.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/task_manager_tester.h

diff --git a/chrome/browser/task_management/task_manager_tester.h b/chrome/browser/task_management/task_manager_tester.h

index def90e91e81ed6331e78098afc426a77513a0c37..b5a8585262de46681adcd1d39e40f0d4abd3040e 100644

--- a/chrome/browser/task_management/task_manager_tester.h

+++ b/chrome/browser/task_management/task_manager_tester.h

@@ -11,14 +11,14 @@

#include "base/callback_forward.h"

#include "base/strings/string16.h"

-#include "chrome/browser/task_manager/task_manager_browsertest_util.h"

+#include "chrome/browser/task_management/task_manager_browsertest_util.h"

namespace task_management {

// An adapter that abstracts away the difference of old vs. new task manager.

class TaskManagerTester {

afakhry 2016/05/07 00:31:51 Should that also be under browsertest_utils?

ncarter (slow) 2016/05/07 22:17:21 No. The browsertest_utils namespace is just that f

afakhry 2016/05/09 17:57:41 Sounds good.

public:

- using ColumnSpecifier = task_manager::browsertest_util::ColumnSpecifier;

+ using ColumnSpecifier = browsertest_util::ColumnSpecifier;

// Creates a TaskManagerTester backed by the current task manager. The task

// manager should already be visible when you call this function. |callback|,