chrome/browser/task_management/DEPS - Issue 1953383002: [Part 6 of 6] Move browsertests and utils to task_management/ directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/task_management/DEPS

Issue 1953383002: [Part 6 of 6] Move browsertests and utils to task_management/ directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tm_file_split5

Patch Set: Comment fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/task_management/task_manager_browsertest.cc » ('j') | chrome/browser/task_management/task_manager_tester.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+extensions/strings/grit/extensions_strings.h"	2 "+extensions/strings/grit/extensions_strings.h"
	afakhry 2016/05/07 00:31:51 Why? Why? ncarter (slow) 2016/05/07 22:17:21 IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX Show quoted text On 2016/05/07 00:31:51, afakhry wrote: > Why? IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX afakhry 2016/05/09 17:57:41 That's weird. I'm not seeing the ID: IDS_EXTENSION Show quoted text On 2016/05/07 22:17:21, ncarter wrote: > On 2016/05/07 00:31:51, afakhry wrote: > > Why? > > IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX That's weird. I'm not seeing the ID: IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX being used anywhere in c/b/task_management, while I can see it being used in the old c/b/task_manager. What am I missing? oh, I guess now we'll be using it now in task_management/ after the move. But GuestTask is different in that it gets the prefix from the GuestViewBase itself. But anyways, aren't we allowed to include extensions_strings.h here by default? Why do we need DEPS? I thought DEPS are used to limit the includes to certain components. ncarter (slow) 2016/05/09 19:19:55 Right, task_management gets IDS_EXTENSION_TASK_MAN Show quoted text On 2016/05/09 17:57:41, afakhry wrote: > On 2016/05/07 22:17:21, ncarter wrote: > > On 2016/05/07 00:31:51, afakhry wrote: > > > Why? > > > > IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX > > That's weird. I'm not seeing the ID: > IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX being used anywhere in > c/b/task_management, while I can see it being used in the old c/b/task_manager. > What am I missing? > > oh, I guess now we'll be using it now in task_management/ after the move. But > GuestTask is different in that it gets the prefix from the GuestViewBase itself. > > But anyways, aren't we allowed to include extensions_strings.h here by default? > Why do we need DEPS? I thought DEPS are used to limit the includes to certain > components. Right, task_management gets IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX via GuestViewBase::GetTaskPrefix(). However, since that's not a static method, we can't easily call from MatchWebview(), without an instance. DEPS is used to enforce layering generally, including but not limited to components. "extensions/strings" is a component, and #including it here is a checkdeps error without this change, because there's no higher-level rule allowing it (i.e. there's no + rule in chrome/DEPS or chrome/browser/DEPS).
3 ]	3 ]

OLD	NEW