Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1953333002: Return a null Platform.executable and resolvedExecutable on Android (Closed)

Created:
4 years, 7 months ago by jsimmons1
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M runtime/bin/platform.h View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/bin/platform.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jsimmons1
4 years, 7 months ago (2016-05-06 19:55:39 UTC) #3
rmacnak
lgtm
4 years, 7 months ago (2016-05-06 21:11:14 UTC) #4
jsimmons1
On 2016/05/06 19:55:39, jsimmons1 wrote: Removed the assert from Platform_ExecutableName. Platform::GetExecutableName() is now allowed to ...
4 years, 7 months ago (2016-05-06 21:18:55 UTC) #5
jsimmons1
4 years, 7 months ago (2016-05-06 21:29:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7eb43c213442b9cbc0a1a345603f4cd045292ab2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698