Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1953313002: Eliminate PlatformWindowMus::Activate (Closed)

Created:
4 years, 7 months ago by Mark Dittmer
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate PlatformWindowMus::Activate BUG=609555 Committed: https://crrev.com/c64d94a0fa41fc29a4d3636793270242cf4af236 Cr-Commit-Position: refs/heads/master@{#392344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M ui/views/mus/native_widget_mus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/platform_window_mus.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Mark Dittmer
sadrul@chromium.org: PTAL.
4 years, 7 months ago (2016-05-06 18:49:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953313002/1
4 years, 7 months ago (2016-05-06 18:50:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 19:38:38 UTC) #6
sadrul
lgtm
4 years, 7 months ago (2016-05-09 15:46:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953313002/1
4 years, 7 months ago (2016-05-09 16:22:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 17:09:03 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:10:23 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c64d94a0fa41fc29a4d3636793270242cf4af236
Cr-Commit-Position: refs/heads/master@{#392344}

Powered by Google App Engine
This is Rietveld 408576698