Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: include/v8.h

Issue 1953263002: [API] Remove deprecated WeakCallbackData and related functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8-util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 479a2f886b0e0f7548a922c80befe86ef8deb922..9a881f2383ce6e6107c7c3da77f234113e62749f 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -457,29 +457,6 @@ class WeakCallbackInfo {
};
-template <class T, class P>
-class WeakCallbackData {
- public:
- typedef void (*Callback)(const WeakCallbackData<T, P>& data);
-
- WeakCallbackData(Isolate* isolate, P* parameter, Local<T> handle)
- : isolate_(isolate), parameter_(parameter), handle_(handle) {}
-
- V8_INLINE Isolate* GetIsolate() const { return isolate_; }
- V8_INLINE P* GetParameter() const { return parameter_; }
- V8_INLINE Local<T> GetValue() const { return handle_; }
-
- private:
- Isolate* isolate_;
- P* parameter_;
- Local<T> handle_;
-};
-
-
-// TODO(dcarney): delete this with WeakCallbackData
-template <class T>
-using PhantomCallbackData = WeakCallbackInfo<T>;
-
// kParameter will pass a void* parameter back to the callback, kInternalFields
// will pass the first two internal fields back to the callback, kFinalizer
// will pass a void* parameter back, but is invoked before the object is
@@ -564,32 +541,6 @@ template <class T> class PersistentBase {
* critical form of resource management!
*/
template <typename P>
- V8_INLINE V8_DEPRECATED(
- "use WeakCallbackInfo version",
- void SetWeak(P* parameter,
- typename WeakCallbackData<T, P>::Callback callback));
-
- template <typename S, typename P>
- V8_INLINE V8_DEPRECATED(
- "use WeakCallbackInfo version",
- void SetWeak(P* parameter,
- typename WeakCallbackData<S, P>::Callback callback));
-
- // Phantom persistents work like weak persistents, except that the pointer to
- // the object being collected is not available in the finalization callback.
- // This enables the garbage collector to collect the object and any objects
- // it references transitively in one GC cycle. At the moment you can either
- // specify a parameter for the callback or the location of two internal
- // fields in the dying object.
- template <typename P>
- V8_INLINE V8_DEPRECATED(
- "use SetWeak",
- void SetPhantom(P* parameter,
- typename WeakCallbackInfo<P>::Callback callback,
- int internal_field_index1 = -1,
- int internal_field_index2 = -1));
-
- template <typename P>
V8_INLINE void SetWeak(P* parameter,
typename WeakCallbackInfo<P>::Callback callback,
WeakCallbackType type);
@@ -6677,9 +6628,6 @@ class V8_EXPORT V8 {
internal::Object** handle);
static internal::Object** CopyPersistent(internal::Object** handle);
static void DisposeGlobal(internal::Object** global_handle);
- typedef WeakCallbackData<Value, void>::Callback WeakCallback;
- static void MakeWeak(internal::Object** global_handle, void* data,
- WeakCallback weak_callback);
static void MakeWeak(internal::Object** global_handle, void* data,
WeakCallbackInfo<void>::Callback weak_callback,
WeakCallbackType type);
@@ -7652,39 +7600,6 @@ void PersistentBase<T>::Reset(Isolate* isolate,
template <class T>
-template <typename S, typename P>
-void PersistentBase<T>::SetWeak(
- P* parameter,
- typename WeakCallbackData<S, P>::Callback callback) {
- TYPE_CHECK(S, T);
- typedef typename WeakCallbackData<Value, void>::Callback Callback;
- V8::MakeWeak(reinterpret_cast<internal::Object**>(this->val_), parameter,
- reinterpret_cast<Callback>(callback));
-}
-
-
-template <class T>
-template <typename P>
-void PersistentBase<T>::SetWeak(
- P* parameter,
- typename WeakCallbackData<T, P>::Callback callback) {
- SetWeak<T, P>(parameter, callback);
-}
-
-
-template <class T>
-template <typename P>
-void PersistentBase<T>::SetPhantom(
- P* parameter, typename WeakCallbackInfo<P>::Callback callback,
- int internal_field_index1, int internal_field_index2) {
- typedef typename WeakCallbackInfo<void>::Callback Callback;
- V8::MakeWeak(reinterpret_cast<internal::Object**>(this->val_), parameter,
- internal_field_index1, internal_field_index2,
- reinterpret_cast<Callback>(callback));
-}
-
-
-template <class T>
template <typename P>
V8_INLINE void PersistentBase<T>::SetWeak(
P* parameter, typename WeakCallbackInfo<P>::Callback callback,
« no previous file with comments | « no previous file | include/v8-util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698