Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1953263002: [API] Remove deprecated WeakCallbackData and related functions. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[API] Remove deprecated WeakCallbackData and related functions. This removes: - PersistentBase::SetWeak that takes WeakCallbackData. The embedders should use the version that takes WeakCallbackInfo. - PersistentBase::SetPhantom. The embedders should SetWeak that takes WeakCallbackInfo. Functions in DefaultPersistentValueMapTraits are changed to accept WeakCallbackInfo instead of WeakCallbackData. BUG=chromium:609808 LOG=NO Committed: https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb Cr-Commit-Position: refs/heads/master@{#36079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -163 lines) Patch
M include/v8.h View 4 chunks +0 lines, -85 lines 0 comments Download
M include/v8-util.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/global-handles.h View 4 chunks +1 line, -15 lines 0 comments Download
M src/global-handles.cc View 10 chunks +10 lines, -44 lines 0 comments Download
M src/profiler/allocation-tracker.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/profiler/allocation-tracker.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal
4 years, 7 months ago (2016-05-06 12:21:21 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-06 12:23:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953263002/1
4 years, 7 months ago (2016-05-06 12:46:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 13:17:49 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 13:18:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb
Cr-Commit-Position: refs/heads/master@{#36079}

Powered by Google App Engine
This is Rietveld 408576698