[fuzzer] Force a GC before shutting down isolates

[fuzzer] Force a GC before shutting down isolates

We just deleted a persistent the line before, so make sure the context
is cleared up before disposing the isolate

R=ulan@chromium.org
BUG=

Committed: https://crrev.com/fbe0f303a238950faf026d2a9c895e75ecf3d05c
Cr-Commit-Position: refs/heads/master@{#36078}

[ulan, 2016-05-06 12:27:12]

lgtm with one suggestion (feel free to ignore).

https://codereview.chromium.org/1953253003/diff/1/test/fuzzer/fuzzer-support.cc
File test/fuzzer/fuzzer-support.cc (right):

https://codereview.chromium.org/1953253003/diff/1/test/fuzzer/fuzzer-support....
test/fuzzer/fuzzer-support.cc:71: isolate_->LowMemoryNotification();
Wouldn't RequestGarbageCollectionForTesting be more descriptive here?

[jochen (gone - plz use gerrit), 2016-05-06 12:28:01]

On 2016/05/06 at 12:27:12, ulan wrote:
> lgtm with one suggestion (feel free to ignore).
> 
>
https://codereview.chromium.org/1953253003/diff/1/test/fuzzer/fuzzer-support.cc
> File test/fuzzer/fuzzer-support.cc (right):
> 
>
https://codereview.chromium.org/1953253003/diff/1/test/fuzzer/fuzzer-support....
> test/fuzzer/fuzzer-support.cc:71: isolate_->LowMemoryNotification();
> Wouldn't RequestGarbageCollectionForTesting be more descriptive here?

that requires more magic though... need to expose-gc, and one round might or
might not be enough.

[jochen (gone - plz use gerrit), 2016-05-06 12:28:09]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-05-06 12:28:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953253003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953253003/1

[commit-bot: I haz the power, 2016-05-06 12:52:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-06 12:53:36]

Description was changed from

==========
[fuzzer] Force a GC before shutting down isolates

We just deleted a persistent the line before, so make sure the context
is cleared up before disposing the isolate

R=ulan@chromium.org
BUG=
==========

to

==========
[fuzzer] Force a GC before shutting down isolates

We just deleted a persistent the line before, so make sure the context
is cleared up before disposing the isolate

R=ulan@chromium.org
BUG=

Committed: https://crrev.com/fbe0f303a238950faf026d2a9c895e75ecf3d05c
Cr-Commit-Position: refs/heads/master@{#36078}
==========

[commit-bot: I haz the power, 2016-05-06 12:53:37]

Patchset 1 (id:??) landed as
https://crrev.com/fbe0f303a238950faf026d2a9c895e75ecf3d05c
Cr-Commit-Position: refs/heads/master@{#36078}