Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 19532: Fix issue 3427 (Support ---app www.foo.com) (Closed)

Created:
11 years, 10 months ago by Brian Duff
Modified:
9 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Passes incoming URL text for the --app switch through URLFixerUpper before constructing a GURL. BUG=3427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/browser_init.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Brian Duff
11 years, 10 months ago (2009-02-02 01:32:27 UTC) #1
Finnur
LGTM, although I believe you are supposed to use std::wstring() instead of L"" (nit). Do ...
11 years, 10 months ago (2009-02-02 18:15:55 UTC) #2
Finnur
This patch is no longer valid since the code block it modifies has been removed. ...
11 years, 10 months ago (2009-02-03 16:54:14 UTC) #3
Finnur
Is this issue still valid? On 2009/02/03 16:54:14, Finnur wrote: > This patch is no ...
11 years, 5 months ago (2009-06-29 23:25:52 UTC) #4
Finnur
11 years, 5 months ago (2009-06-30 01:08:39 UTC) #5
> The bug no longer reproduces in a trunk linux build I just made.
> Thanks,
> Brian

Thanks, I'll close this issue then.

On 2009/06/29 23:25:52, Finnur wrote:
> Is this issue still valid?
> 
> On 2009/02/03 16:54:14, Finnur wrote:
> > This patch is no longer valid since the code block it modifies has been
> removed.
> > Can you resync, see if the problem still remains and add your fix to the
right
> > place?
> > 
> > On 2009/02/02 18:15:55, Finnur wrote:
> > > LGTM, although I believe you are supposed to use std::wstring() instead of
> L""
> > > (nit).
> > > 
> > > Do you need someone to check this in for you, or do you have access?
> > > 
> > > 
> > > On 2009/02/02 01:32:27, Brian Duff wrote:
> > > >

Powered by Google App Engine
This is Rietveld 408576698