Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1953183002: Support the ignored_by_shelf flag for Mus windows. (Closed)

Created:
4 years, 7 months ago by msw
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org, James Cook
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support the ignored_by_shelf flag for Mus windows. Aura window state supports an ignored_by_shelf flag. (this is used by the browser window status bubble, etc.) Add similar support for Mus windows via a new property. Add kWindowIgnoredByShelf_Property to window_manager.mojom Add GetWindowIgnoredByShelf utility function. Add a bool<->std::vector<uint8_t> property converter. Add a map of mus window properties to widget init params. (allows setting properties before a window is created) Copy these to the mus window in NativeWidgetMus. Add UserWindow ignored_by_shelf flag. Apply this property to the status area bubble. TODO: Apply to other existing users; support setting later? BUG=557406 TEST=A Chrome window in Mash only shows a single shelf item. R=sky@chromium.org Committed: https://crrev.com/77c54f3d185478bd83275d67d7bd9f83547d79bb Cr-Commit-Position: refs/heads/master@{#392167}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Fix deps and limit mus to MOJO_SHELL_CLIENT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M ash/mus/shelf_delegate_mus.cc View 1 5 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/property_type_converters.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M components/mus/public/cpp/property_type_converters.h View 1 chunk +9 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/wm/property_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/wm/property_util.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M mash/wm/public/interfaces/user_window_controller.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/user_window_controller_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 7 months ago (2016-05-05 21:58:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953183002/40001
4 years, 7 months ago (2016-05-05 21:59:40 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/62124)
4 years, 7 months ago (2016-05-05 22:12:20 UTC) #8
sky
LGTM
4 years, 7 months ago (2016-05-05 23:52:52 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953183002/60001
4 years, 7 months ago (2016-05-06 18:18:23 UTC) #11
msw
Hey Scott, please check the latest patch set; thanks!
4 years, 7 months ago (2016-05-06 19:10:46 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 20:21:02 UTC) #14
sky
LGTM
4 years, 7 months ago (2016-05-06 21:39:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953183002/60001
4 years, 7 months ago (2016-05-06 21:42:13 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-06 21:47:21 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 21:48:28 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/77c54f3d185478bd83275d67d7bd9f83547d79bb
Cr-Commit-Position: refs/heads/master@{#392167}

Powered by Google App Engine
This is Rietveld 408576698