Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1953173002: GN file updates to support using dbc. (Closed)

Created:
4 years, 7 months ago by Chinmay
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Revert CC changes #

Patch Set 3 : GN file updates to support using dbc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M runtime/BUILD.gn View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Chinmay
Ryan: Using the |dart_runtime_mode| mode to decide switching the |dart_target_arch| was breaking iOS simulator builds. ...
4 years, 7 months ago (2016-05-05 21:19:33 UTC) #2
rmacnak
gn changes lgtm cc changes not needed after the more comprehensive 78de302495ad5470da30dc7337e15d4ec7c7ee40
4 years, 7 months ago (2016-05-05 23:01:16 UTC) #3
Chinmay
Committed patchset #3 (id:40001) manually as 269bcf9bf8ce1487a8c53f52c3f95b28ea0958f0 (presubmit successful).
4 years, 7 months ago (2016-05-06 00:08:14 UTC) #5
Chinmay
4 years, 7 months ago (2016-05-06 00:08:45 UTC) #6
Message was sent while issue was closed. 
On 2016/05/06 at 00:08:14, Chinmay wrote:
> Committed patchset #3 (id:40001) manually as
269bcf9bf8ce1487a8c53f52c3f95b28ea0958f0 (presubmit successful).

I backed out the cc changes. Only GN changes committed.

Powered by Google App Engine
This is Rietveld 408576698