SkAdvancedTypefaceMetrics: abstract out linked list

SkAdvancedTypefaceMetrics: abstract out linked list

+ use SkSinglyLinkedList<T>
+ move SkSinglyLinkedList.h to core
+ remove SkHackyAutoTDelete
+ getAdvanceData() -> setGlyphWidths()
+ finishRange no longer templated
+ remove unused templated functions

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1953153004

Committed: https://skia.googlesource.com/skia/+/e20a87517043ec4a30dcc7e711ca49087e8942ff

[hal.canary, 2016-05-06 18:49:10]

Description was changed from

==========
SkAdvancedTypefaceMetrics: abstract out linked list
==========

to

==========
SkAdvancedTypefaceMetrics: abstract out linked list
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-05-06 18:49:31]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2016-05-06 18:49:37]

Description was changed from

==========
SkAdvancedTypefaceMetrics: abstract out linked list
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkAdvancedTypefaceMetrics: abstract out linked list

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-05-06 18:49:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953153004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953153004/1

[commit-bot: I haz the power, 2016-05-06 18:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 18:53:52]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2016-05-06 19:00:17]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 19:00:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953153004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953153004/20001

[hal.canary, 2016-05-06 19:01:45]

Patchset #2 (id:20001) has been deleted

[hal.canary, 2016-05-06 19:01:54]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 19:02:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953153004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953153004/40001

[commit-bot: I haz the power, 2016-05-06 19:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 19:04:32]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2016-05-06 19:32:24]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 19:32:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953153004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953153004/60001

[commit-bot: I haz the power, 2016-05-06 19:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 19:53:24]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-05-06 19:58:04]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2016-05-06 19:58:04]

PTAL

[reed1, 2016-05-06 20:07:12]

reed@google.com changed reviewers:
+ bungeman@google.com, reed@google.com

[hal.canary, 2016-05-06 20:55:06]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2016-05-06 20:55:13]

Patchset #4 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-05-06 20:55:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953153004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953153004/100001

[hal.canary, 2016-05-06 20:55:24]

Patchset #2 (id:40001) has been deleted

[hal.canary, 2016-05-06 20:55:32]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-05-06 20:57:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 20:57:44]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2016-05-06 21:00:47]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 21:00:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953153004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953153004/120001

[hal.canary, 2016-05-06 21:09:10]

Patchset #2 (id:100001) has been deleted

[hal.canary, 2016-05-06 21:10:26]

Description was changed from

==========
SkAdvancedTypefaceMetrics: abstract out linked list

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkAdvancedTypefaceMetrics: abstract out linked list

+ use SkSinglyLinkedList<T>
+ move SkSinglyLinkedList.h to core
+ remove SkHackyAutoTDelete
+ getAdvanceData() -> setGlyphWidths()
+ finishRange no longer templated
+ remove unused templated functions

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-05-06 21:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 21:23:26]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-05-09 00:38:00]

lgtm

[hal.canary, 2016-05-09 01:26:17]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-05-09 01:26:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953153004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953153004/120001

[commit-bot: I haz the power, 2016-05-09 01:47:24]

Description was changed from

==========
SkAdvancedTypefaceMetrics: abstract out linked list

+ use SkSinglyLinkedList<T>
+ move SkSinglyLinkedList.h to core
+ remove SkHackyAutoTDelete
+ getAdvanceData() -> setGlyphWidths()
+ finishRange no longer templated
+ remove unused templated functions

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkAdvancedTypefaceMetrics: abstract out linked list

+ use SkSinglyLinkedList<T>
+ move SkSinglyLinkedList.h to core
+ remove SkHackyAutoTDelete
+ getAdvanceData() -> setGlyphWidths()
+ finishRange no longer templated
+ remove unused templated functions

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e20a87517043ec4a30dcc7e711ca49087e8942ff
==========

[commit-bot: I haz the power, 2016-05-09 01:47:26]

Committed patchset #2 (id:120001) as
https://skia.googlesource.com/skia/+/e20a87517043ec4a30dcc7e711ca49087e8942ff