Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1953153002: Update dart:async to match the Dart repo. (Closed)

Created:
4 years, 7 months ago by Bob Nystrom
Modified:
4 years, 7 months ago
Reviewers:
vsm, sra
CC:
dev-compiler+reviews_dartlang.org, vsm
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unneeded calls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3071 lines, -2169 lines) Patch
M lib/runtime/dart_sdk.js View 1 187 chunks +1507 lines, -1144 lines 0 comments Download
M test/browser/language_tests.js View 2 chunks +0 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/async/async.dart View 1 chunk +17 lines, -16 lines 0 comments Download
M tool/input_sdk/lib/async/async_error.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M tool/input_sdk/lib/async/broadcast_stream_controller.dart View 14 chunks +97 lines, -64 lines 0 comments Download
M tool/input_sdk/lib/async/future.dart View 10 chunks +48 lines, -13 lines 0 comments Download
M tool/input_sdk/lib/async/future_impl.dart View 18 chunks +277 lines, -191 lines 0 comments Download
M tool/input_sdk/lib/async/schedule_microtask.dart View 4 chunks +29 lines, -15 lines 0 comments Download
M tool/input_sdk/lib/async/stream.dart View 39 chunks +247 lines, -98 lines 0 comments Download
M tool/input_sdk/lib/async/stream_controller.dart View 25 chunks +255 lines, -110 lines 0 comments Download
M tool/input_sdk/lib/async/stream_impl.dart View 30 chunks +70 lines, -58 lines 0 comments Download
M tool/input_sdk/lib/async/stream_pipe.dart View 10 chunks +78 lines, -21 lines 0 comments Download
M tool/input_sdk/lib/async/stream_transformers.dart View 4 chunks +10 lines, -8 lines 0 comments Download
M tool/input_sdk/lib/async/timer.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/async/zone.dart View 37 chunks +412 lines, -360 lines 0 comments Download
M tool/input_sdk/patch/async_patch.dart View 1 2 chunks +11 lines, -3 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 chunks +1 line, -60 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bob Nystrom
4 years, 7 months ago (2016-05-05 21:01:53 UTC) #2
vsm
lgtm! https://codereview.chromium.org/1953153002/diff/1/tool/input_sdk/patch/async_patch.dart File tool/input_sdk/patch/async_patch.dart (right): https://codereview.chromium.org/1953153002/diff/1/tool/input_sdk/patch/async_patch.dart#newcode10 tool/input_sdk/patch/async_patch.dart:10: convertDartClosureToJS; Note - this is just identity on ...
4 years, 7 months ago (2016-05-05 21:23:40 UTC) #4
Bob Nystrom
Committed patchset #2 (id:20001) manually as 8154650779ea579e4d599ad422e459305b405eac (presubmit successful).
4 years, 7 months ago (2016-05-05 22:03:15 UTC) #6
Bob Nystrom
4 years, 7 months ago (2016-05-05 22:03:46 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1953153002/diff/1/tool/input_sdk/patch/async_...
File tool/input_sdk/patch/async_patch.dart (right):

https://codereview.chromium.org/1953153002/diff/1/tool/input_sdk/patch/async_...
tool/input_sdk/patch/async_patch.dart:10: convertDartClosureToJS;
On 2016/05/05 21:23:40, vsm wrote:
> Note - this is just identity on the first arg in DDC.  You could drop it.

Done.

Powered by Google App Engine
This is Rietveld 408576698