Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 195313003: [SVG2] Add getters and setters to SVG*List interfaces. (Closed)

Created:
6 years, 9 months ago by Erik Dahlström (inactive)
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, eae+blinkwatch, fs, Steve Block, dino_apple.com, rwlbuis, krit, arv+blink, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, dstockwell, Timothy Loh, jchaffraix+rendering, Eric Willigers, rjwright, zoltan1, gyuyoung.kim_webkit.org, darktears, kouhei+svg_chromium.org, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add svg*list tests #

Patch Set 3 : test expectations #

Patch Set 4 : rebased #

Patch Set 5 : tryserver rebase #

Total comments: 1

Patch Set 6 : s/slength/size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -71 lines) Patch
A LayoutTests/fast/svg/svglist.html View 1 1 chunk +136 lines, -0 lines 0 comments Download
A LayoutTests/fast/svg/svglist-expected.txt View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M Source/core/animation/AnimatableValueTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthList.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGLengthList.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGNumberList.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/svg/SVGNumberList.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegList.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPointList.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGPointList.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStringList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStringList.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStringListTearOff.h View 2 chunks +8 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTransformList.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTransformList.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/svg/properties/NewSVGListPropertyHelper.h View 1 2 3 4 5 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/properties/NewSVGListPropertyTearOffHelper.h View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kouhei (in TOK)
Looks great! Would you add layout test for this?
6 years, 9 months ago (2014-03-12 00:50:23 UTC) #1
Erik Dahlström (inactive)
On 2014/03/12 00:50:23, kouhei wrote: > Looks great! Would you add layout test for this? ...
6 years, 9 months ago (2014-03-12 07:53:18 UTC) #2
Erik Dahlström (inactive)
I should note that Firefox passes the test except for the setter part, which apparently ...
6 years, 9 months ago (2014-03-14 10:00:02 UTC) #3
fs
Non-owner LGTM.
6 years, 9 months ago (2014-03-14 16:10:07 UTC) #4
pdr.
On 2014/03/14 16:10:07, fs wrote: > Non-owner LGTM. LGTM2
6 years, 9 months ago (2014-03-14 17:15:22 UTC) #5
pdr.
https://codereview.chromium.org/195313003/diff/80001/Source/core/svg/properties/NewSVGListPropertyHelper.h File Source/core/svg/properties/NewSVGListPropertyHelper.h (right): https://codereview.chromium.org/195313003/diff/80001/Source/core/svg/properties/NewSVGListPropertyHelper.h#newcode174 Source/core/svg/properties/NewSVGListPropertyHelper.h:174: size_t slength = length(); size?
6 years, 9 months ago (2014-03-14 17:18:38 UTC) #6
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 9 months ago (2014-03-17 08:06:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/195313003/100001
6 years, 9 months ago (2014-03-17 08:06:49 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 08:40:49 UTC) #9
Message was sent while issue was closed.
Change committed as 169332

Powered by Google App Engine
This is Rietveld 408576698