GoogleChromeCompatibilityCheck in gcapi return false for Windows XP and Vista

chrome/installer/gcapi/gcapi.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NOTE: This code is a legacy utility API for partners to check whether
 //       Chrome can be installed and launched. Recent updates are being made
 //       to add new functionality. These updates use code from Chromium, the old
 //       coded against the win32 api directly. If you have an itch to shave a
 //       yak, feel free to re-write the old code too.
 
@@ skipping 209 matching lines @@
   // The C1F RLZ key can either be in HKCU or in HKLM (the HKLM RLZ key is made
   // readable to all-users via rlz_lib::CreateMachineState()) and can either be
   // in sent or pending state. Return true if there is a match for any of these
   // 4 states.
   return RegKeyHasC1F(HKEY_CURRENT_USER, kC1FSentKey) ||
       RegKeyHasC1F(HKEY_CURRENT_USER, kC1FPendingKey) ||
       RegKeyHasC1F(HKEY_LOCAL_MACHINE, kC1FSentKey) ||
       RegKeyHasC1F(HKEY_LOCAL_MACHINE, kC1FPendingKey);
 }
 
-enum WindowsVersion {
-  VERSION_BELOW_XP_SP2,
-  VERSION_XP_SP2_UP_TO_VISTA,  // "but not including"
-  VERSION_VISTA_OR_HIGHER,
-};
-WindowsVersion GetWindowsVersion() {
+bool IsWindowsVersionSupported() {
   OSVERSIONINFOEX version_info = { sizeof version_info };
   GetVersionEx(reinterpret_cast<OSVERSIONINFO*>(&version_info));
 
-  // Windows Vista is version 6.0.
-  if (version_info.dwMajorVersion >= 6)
-    return VERSION_VISTA_OR_HIGHER;
+  // Windows 7 is version 6.1.
+  if (version_info.dwMajorVersion > 6 ||
+      (version_info.dwMajorVersion == 6 && version_info.dwMinorVersion > 0))
+    return true;
 
-  // Windows XP is version 5.1.  (5.2 is Windows Server 2003/XP Pro x64.)
-  if ((version_info.dwMajorVersion < 5) || (version_info.dwMinorVersion < 1))
-    return VERSION_BELOW_XP_SP2;
-
-  // For XP itself, we only support SP2 and above.
-  return ((version_info.dwMinorVersion > 1) ||
-          (version_info.wServicePackMajor >= 2)) ?
-      VERSION_XP_SP2_UP_TO_VISTA : VERSION_BELOW_XP_SP2;
+  return false;
 }
 
 // Note this function should not be called on old Windows versions where these
 // Windows API are not available. We always invoke this function after checking
 // that current OS is Vista or later.
 bool VerifyAdminGroup() {
   SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
   PSID Group;
   BOOL check = ::AllocateAndInitializeSid(&NtAuthority, 2,
                                           SECURITY_BUILTIN_DOMAIN_RID,
@@ skipping 29 matching lines @@
     //  If we create the main key, delete the entire key.
     if (disposition == REG_CREATED_NEW_KEY)
       RegDeleteKey(HKEY_LOCAL_MACHINE, kGCAPITempKey);
   }
 
   return result;
 }
 
 bool IsRunningElevated() {
   // This method should be called only for Vista or later.
-  if ((GetWindowsVersion() < VERSION_VISTA_OR_HIGHER) ||
-      !VerifyAdminGroup())
+  if (!IsWindowsVersionSupported() || !VerifyAdminGroup())
     return false;
 
   HANDLE process_token;
   if (!::OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY, &process_token))
     return false;
 
   TOKEN_ELEVATION_TYPE elevation_type = TokenElevationTypeDefault;
   DWORD size_returned = 0;
   if (!::GetTokenInformation(process_token, TokenElevationType,
                              &elevation_type, sizeof(elevation_type),
@@ skipping 87 matching lines @@
   return !chrome_exe_path->empty();
 }
 
 }  // namespace
 
 BOOL __stdcall GoogleChromeCompatibilityCheck(BOOL set_flag,
                                               int shell_mode,
                                               DWORD* reasons) {
   DWORD local_reasons = 0;
 
-  WindowsVersion windows_version = GetWindowsVersion();
+  bool is_windows_version_supported = IsWindowsVersionSupported();
   // System requirements?
-  if (windows_version == VERSION_BELOW_XP_SP2)
+  if (!is_windows_version_supported)
     local_reasons |= GCCC_ERROR_OSNOTSUPPORTED;
 
   if (IsChromeInstalled(HKEY_LOCAL_MACHINE))
     local_reasons |= GCCC_ERROR_SYSTEMLEVELALREADYPRESENT;
 
   if (IsChromeInstalled(HKEY_CURRENT_USER))
     local_reasons |= GCCC_ERROR_USERLEVELALREADYPRESENT;
 
   if (shell_mode == GCAPI_INVOKED_UAC_ELEVATION) {
     // Only check that we have HKLM write permissions if we specify that
     // GCAPI is being invoked from an elevated shell, or in admin mode
     if (!VerifyHKLMAccess()) {
     local_reasons |= GCCC_ERROR_ACCESSDENIED;
-    } else if ((windows_version == VERSION_VISTA_OR_HIGHER) &&
-         !VerifyAdminGroup()) {
-    // For Vista or later check for elevation since even for admin user we could
-    // be running in non-elevated mode. We require integrity level High.
-    local_reasons |= GCCC_ERROR_INTEGRITYLEVEL;
+    } else if (is_windows_version_supported && !VerifyAdminGroup()) {
+      // For Vista or later check for elevation since even for admin user we
+      // could be running in non-elevated mode. We require integrity level High.
+      local_reasons |= GCCC_ERROR_INTEGRITYLEVEL;
     }
   }
 
   // Then only check whether we can re-offer, if everything else is OK.
   if (local_reasons == 0 && !CanReOfferChrome(set_flag))
     local_reasons |= GCCC_ERROR_ALREADYOFFERED;
 
   // Done. Copy/return results.
   if (reasons != NULL)
     *reasons = local_reasons;
@@ skipping 349 matching lines @@
       key.WriteValue(kRelaunchAllowedAfterValue,
                      FormatDateOffsetByMonths(6)) != ERROR_SUCCESS ||
       !SetRelaunchExperimentLabels(relaunch_brandcode, shell_mode)) {
     if (error_code)
       *error_code = RELAUNCH_ERROR_RELAUNCH_FAILED;
     return FALSE;
   }
 
   return TRUE;
 }