Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{ 6 * @typedef {{
7 * url: string, 7 * url: string,
8 * page: string, 8 * page: string,
9 * section: string, 9 * section: string,
10 * subpage: !Array<string>, 10 * subpage: !Array<string>,
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 * The 'url' property is not accessible to other elements. 89 * The 'url' property is not accessible to other elements.
90 */ 90 */
91 routes_: [ 91 routes_: [
92 { 92 {
93 url: '/', 93 url: '/',
94 page: 'basic', 94 page: 'basic',
95 section: '', 95 section: '',
96 subpage: [], 96 subpage: [],
97 }, 97 },
98 { 98 {
99 url: '/about',
dschuyler 2016/05/05 21:58:20 It looks like the legacy url is /help.
dpapad 2016/05/05 22:13:53 Done. BTW, If we want to be 100% consistent with
100 page: 'about',
101 section: '',
102 subpage: [],
103 },
104 {
99 url: '/advanced', 105 url: '/advanced',
100 page: 'advanced', 106 page: 'advanced',
101 section: '', 107 section: '',
102 subpage: [], 108 subpage: [],
103 }, 109 },
104 <if expr="chromeos"> 110 <if expr="chromeos">
105 { 111 {
106 url: '/internet', 112 url: '/internet',
107 page: 'basic', 113 page: 'basic',
108 section: 'internet', 114 section: 'internet',
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 window.history.replaceState(historicState, document.title); 533 window.history.replaceState(historicState, document.title);
528 } 534 }
529 535
530 return; 536 return;
531 } 537 }
532 } 538 }
533 539
534 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 540 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
535 }, 541 },
536 }); 542 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698