Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-main' displays the selected settings page. 7 * 'settings-main' displays the selected settings page.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 18 matching lines...) Expand all
29 29
30 /** 30 /**
31 * The current active route. 31 * The current active route.
32 */ 32 */
33 currentRoute: { 33 currentRoute: {
34 type: Object, 34 type: Object,
35 notify: true, 35 notify: true,
36 observer: 'currentRouteChanged_', 36 observer: 'currentRouteChanged_',
37 }, 37 },
38 38
39 // If false the 'basic' page should be shown. 39 /** @private */
40 showAdvancedPage_: { 40 showAdvancedPage_: Boolean,
41 type: Boolean, 41
42 value: false 42 /** @private */
43 } 43 showBasicPage_: Boolean,
44
45 /** @private */
46 showAboutPage_: Boolean,
44 }, 47 },
45 48
46 /** @private */ 49 /** @private */
dschuyler 2016/05/05 21:58:20 nit: @param {SettingsRoute} newRoute blah blah.
dpapad 2016/05/05 22:13:53 Done.
47 currentRouteChanged_: function(newRoute, oldRoute) { 50 currentRouteChanged_: function(newRoute, oldRoute) {
dschuyler 2016/05/05 21:58:20 Let's remove oldRoute (or add an @param for it, bu
dpapad 2016/05/05 22:13:53 Done.
51 this.showAboutPage_ = newRoute.page == 'about';
48 this.showAdvancedPage_ = newRoute.page == 'advanced'; 52 this.showAdvancedPage_ = newRoute.page == 'advanced';
53 this.showBasicPage_ = newRoute.page == 'basic';
49 }, 54 },
50 }); 55 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698