Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1953043002: Extract 'refineBinaryExpressionType' into TypeSystem. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract 'refineBinaryExpressionType' into TypeSystem. This remove duplication and is also a preparation for fixing https://github.com/dart-lang/sdk/issues/25914 R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/597aaa15a411eed74d1a09c64b9fc28e83e28f12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -84 lines) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 3 chunks +12 lines, -54 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 2 chunks +45 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +2 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-05 15:52:26 UTC) #1
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-05 16:02:47 UTC) #2
scheglov
4 years, 7 months ago (2016-05-05 16:03:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
597aaa15a411eed74d1a09c64b9fc28e83e28f12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698