Listen for OutputNodeVolumeChanged signal

When a headset or other application changes the active node's
volume on system, Chrome UI should know that and updates the
stored volume accordingly.

BUG=609458
TEST=Run cras_test_client --set_node_volume on the active node
to verify Chrome UI shows volume bar to reflect the change.

Committed: https://crrev.com/7a0ee45432bf8e1c284216525de2d49421cc3e78
Cr-Commit-Position: refs/heads/master@{#394738}

[jennyz, 2016-05-06 18:11:07]

jennyz@chromium.org changed reviewers:
+ jennyz@chromium.org

[jennyz, 2016-05-06 18:11:08]

https://codereview.chromium.org/1952983002/diff/1/chromeos/audio/cras_audio_h...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/1952983002/diff/1/chromeos/audio/cras_audio_h...
chromeos/audio/cras_audio_handler.cc:581: SetOutputNodeVolumePercent(node_id,
volume);
This will have a glitch for the multiple active nodes case, since it will leave
other active nodes with a different volume node, which might not be the case you
want. You should call CrasAudioHandler::SetOutputVolumePercent to make all the
active nodes set to be same volume level, which is CrasAudioHandler and chromeOS
UI currently assumed.

[hychao, 2016-05-12 08:04:19]

Description was changed from

==========
WIP: Listen for OutputNodeVolumeChanged signal

BUG=TBD
==========

to

==========
When a headset or other application changes the active node's
volume on system, Chrome UI should know that and updates the
stored volume accordingly.
    
BUG=609458
TEST=Run cras_test_client --set_node_volume on the active node
to verify Chrome UI shows volume bar to reflect the change.
==========

[hychao, 2016-05-12 08:06:27]

Thanks for the review.
Comments are added to new added functions in the new patch set and use the CRAS
signal name from system_api.
This will depend on https://codereview.chromium.org/1971073002/

https://codereview.chromium.org/1952983002/diff/1/chromeos/audio/cras_audio_h...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/1952983002/diff/1/chromeos/audio/cras_audio_h...
chromeos/audio/cras_audio_handler.cc:581: SetOutputNodeVolumePercent(node_id,
volume);
On 2016/05/06 18:11:08, jennyz wrote:
> This will have a glitch for the multiple active nodes case, since it will
leave
> other active nodes with a different volume node, which might not be the case
you
> want. You should call CrasAudioHandler::SetOutputVolumePercent to make all the
> active nodes set to be same volume level, which is CrasAudioHandler and
chromeOS
> UI currently assumed.

Done.

[jennyz, 2016-05-16 21:28:59]

lgtm

[hychao, 2016-05-19 07:21:25]

The CQ bit was checked by hychao@chromium.org

[hychao, 2016-05-19 07:21:26]

The patchset sent to the CQ was uploaded after l-g-t-m from jennyz@chromium.org
Link to the patchset: https://codereview.chromium.org/1952983002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-05-19 07:21:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952983002/40001

[commit-bot: I haz the power, 2016-05-19 07:34:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 07:34:44]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hychao, 2016-05-19 09:08:20]

The CQ bit was checked by hychao@chromium.org

[hychao, 2016-05-19 09:08:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jennyz@chromium.org
Link to the patchset: https://codereview.chromium.org/1952983002/#ps60001
(title: "Add unittest")

[commit-bot: I haz the power, 2016-05-19 09:08:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952983002/60001

[commit-bot: I haz the power, 2016-05-19 09:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 09:22:29]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[hychao, 2016-05-19 09:31:44]

The CQ bit was checked by hychao@chromium.org

[commit-bot: I haz the power, 2016-05-19 09:32:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952983002/60001

[commit-bot: I haz the power, 2016-05-19 09:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 09:41:49]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[hychao, 2016-05-19 10:31:45]

The CQ bit was checked by hychao@chromium.org

[hychao, 2016-05-19 10:31:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jennyz@chromium.org
Link to the patchset: https://codereview.chromium.org/1952983002/#ps80001
(title: "Fix unimplemented method")

[commit-bot: I haz the power, 2016-05-19 10:32:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952983002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952983002/80001

[commit-bot: I haz the power, 2016-05-19 11:29:21]

Description was changed from

==========
When a headset or other application changes the active node's
volume on system, Chrome UI should know that and updates the
stored volume accordingly.
    
BUG=609458
TEST=Run cras_test_client --set_node_volume on the active node
to verify Chrome UI shows volume bar to reflect the change.
==========

to

==========
When a headset or other application changes the active node's
volume on system, Chrome UI should know that and updates the
stored volume accordingly.
    
BUG=609458
TEST=Run cras_test_client --set_node_volume on the active node
to verify Chrome UI shows volume bar to reflect the change.
==========

[commit-bot: I haz the power, 2016-05-19 11:29:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-19 11:30:16]

Description was changed from

==========
When a headset or other application changes the active node's
volume on system, Chrome UI should know that and updates the
stored volume accordingly.
    
BUG=609458
TEST=Run cras_test_client --set_node_volume on the active node
to verify Chrome UI shows volume bar to reflect the change.
==========

to

==========
When a headset or other application changes the active node's
volume on system, Chrome UI should know that and updates the
stored volume accordingly.

BUG=609458
TEST=Run cras_test_client --set_node_volume on the active node
to verify Chrome UI shows volume bar to reflect the change.

Committed: https://crrev.com/7a0ee45432bf8e1c284216525de2d49421cc3e78
Cr-Commit-Position: refs/heads/master@{#394738}
==========

[commit-bot: I haz the power, 2016-05-19 11:30:17]

Patchset 5 (id:??) landed as
https://crrev.com/7a0ee45432bf8e1c284216525de2d49421cc3e78
Cr-Commit-Position: refs/heads/master@{#394738}